Convert usages of nerdctl and crt to crictl about kubespray HOT 9 OPEN

from kubespray.

There are significant documents to describe the difference between nerdctl and crictl. :https://www.slideshare.net/AkihiroSuda/container-plumbing-days-2023-why-was-nerdctl-made

For kubespray, using the crictl_image_pull_command as default is a good idea. It can share the same"pull image" codebase with Kubernetes .👍

As notice:

1: If the var setting is:

download_container: true
download_localhost: true

The image_pull_command_on_localhost will run in the machine "ansible localhost"; the machine may not have crictl installed.

2. The registry mirror config of nerdctl and crictl is different.

from kubespray.

Could I try to work on this?
/assign

from kubespray.

As far as I know crictl is compatible with all the container runtimes. So I would go for it.

from kubespray.

Yeah and I just saw it's required by kubeadm anyway, so that's the obvious candidate

from kubespray.

Yes!

Could it be a breaking change during next upgrade for some users?

from kubespray.

/good-first-issue
/help

from kubespray.

@VannTen:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

• Why are we solving this issue?
• To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
• Does this issue have zero to low barrier of entry?
• How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

from kubespray.

from kubespray.