Git Product home page Git Product logo

Comments (9)

hjacobs avatar hjacobs commented on May 22, 2024 2

At least all performed DNS changes should be logged as INFO (one line per change, not some verbose dump).

from external-dns.

hjacobs avatar hjacobs commented on May 22, 2024 1

Also debug logging should include if a change is not performed because of the policy (e.g. a DELETE would be needed but is not allowed by policy).

from external-dns.

hjacobs avatar hjacobs commented on May 22, 2024

@ideahitme can you prepare a small proposal on where to log what? I have some minimum expectations (just what comes to my mind right now):

  • DNS records which are not owned by External DNS should be logged on DEBUG level (so users can clearly see that they are skipped and for what reason)
  • DNS records which are filtered by the --domain option should be logged on DEBUG level (so users can clearly see that they are skipped and for what reason)

from external-dns.

ideahitme avatar ideahitme commented on May 22, 2024

Logging should include (without --debug enabled) :

  • External-dns final changes passed to dns provider - this needs to be logged in DNS Provider mainly due to RecordType information
  • All errors regarding retrieving ingress/service and dns provider API calls:
    • Failure to retrieve ingress/service list, failure to retrieve record list should be logged in controller
    • Failure to update records in a hosted zone, logged in dns provider with zoneID and list of records - this is a rare scenario
  • External-dns has empty update list for dns provider - this should be transparent, i.e. each dns provider call to update records should be concluded with number of owned records (k8s resources) and number of changes pushed to DNS Provider

Debug logging should include:

  • External-dns is unable to determine a hosted zone for the record - this information is only available in DNS provider and should be logged there
  • External-dns is not responsible for the record (TXT record is missing) - this information is only available in TXT Registry
  • External-dns skips endpoint because another controller annotation is present or dnsname could not be figured out - this information should be logged in corresponding source implementation
  • External DNS policy does not allow deletion, this information should be logged with a list of record which are not being deleted due to the policy
  • External DNS resorting to compatibility mode (if flag enabled) should be seen by user - e.g. "mate zalando.org/dnsname annotation is found, using example.org as dns name"
  • External DNS should print general information regarding collected k8s resources [DNSName Target]

from external-dns.

hjacobs avatar hjacobs commented on May 22, 2024

External-dns has empty update list for dns provider

I think this could be a nice summary logging the number of owned records and performed changes.

from external-dns.

fejta-bot avatar fejta-bot commented on May 22, 2024

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

from external-dns.

fejta-bot avatar fejta-bot commented on May 22, 2024

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

from external-dns.

fejta-bot avatar fejta-bot commented on May 22, 2024

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

from external-dns.

k8s-ci-robot avatar k8s-ci-robot commented on May 22, 2024

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

from external-dns.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.