Provide a flag to skip running the Finish function about e2e-framework HOT 9 CLOSED

@dhadukk thanks!

I think what you are asking is a way to fail fast in some situations. That way the test runtime will not reach Finish steps and avoid any clean up.

Workaround

Until that is implemented, one workaround would be to store a value in the context (say, completed). Then only run your specified Finish if completed is true, otherwise skip completion.

from e2e-framework.

Hi @vladimirvivien
Thank you for suggesting the workaround.
If I understand it correctly, I can save one variable in contaxt called completed which is common for all the feature sets(test functions). Before each test I should do completed=false and aftereachtest completed=true. Finish should execute only if completed=true.

from e2e-framework.

@dhadukk Yes, hope this made sense.
This would be a workaround until we can figure out a better way.

from e2e-framework.

Thank you @vladimirvivien This make sense.

from e2e-framework.

@dhadukk please let us know, here, if this workaround works for you.

Thanks.

from e2e-framework.

Hi Vladimir, We have not implemented this logic as every time something fails, we can not afford to clean up manually.
Currently, if something fails and if we want to debug the failure we manually comment the finish function and skip the cleanup. Thank you.

from e2e-framework.

@dhadukk we are actively looking at this to provide and escape hatch if something goes wrong. See #118

from e2e-framework.

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

from e2e-framework.

This issue can be closed, feature was implemented in #118 .

from e2e-framework.