Git Product home page Git Product logo

Comments (10)

christopherhein avatar christopherhein commented on August 9, 2024 1

/close
Thanks folks for all your help on this! 🎉
https://groups.google.com/g/kubernetes-sig-cluster-lifecycle/c/Woe731ONmBc

from cluster-api-provider-nested.

k8s-ci-robot avatar k8s-ci-robot commented on August 9, 2024

@christopherhein: The provided milestone is not valid for this repository. Milestones in this repository: [next, v0.1.0, v0.1.x]

Use /milestone clear to clear the milestone.

In response to this:

Instructions here https://www.kubernetes.dev/resources/rename/

/kind cleanup
/wg naming
/milestone Next

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

from cluster-api-provider-nested.

christopherhein avatar christopherhein commented on August 9, 2024

/milestone v0.1.x

from cluster-api-provider-nested.

christopherhein avatar christopherhein commented on August 9, 2024

/assign @kubernetes/owners

As per - https://www.kubernetes.dev/resources/rename/#approval

from cluster-api-provider-nested.

spiffxp avatar spiffxp commented on August 9, 2024

So I see you checked a bunch of boxes but what exactly did you do? Do you have links to PRs or descriptions of why you're good to go?

from cluster-api-provider-nested.

christopherhein avatar christopherhein commented on August 9, 2024

@spiffxp we didn't have a lot of work since this is a relatively new repo, we only have one Prow job which was added recently with this issue in mind - https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes-sigs/cluster-api-provider-nested/cluster-api-provider-nested-presubmits.yaml#L10 and in those the scripts that are called act solely on the branch that was pulled. Both branch_protection and milestone_applier haven't been configured yet.

Additionally, We discussed this on today's CAPN Office hours as well - https://www.youtube.com/watch?v=-bbUzYKHFls&t=5s to pre-emptively get folks ready for when the change goes into effect.

from cluster-api-provider-nested.

spiffxp avatar spiffxp commented on August 9, 2024

You'll want to take care of

$(GO_APIDIFF) $(shell git rev-parse origin/master) --print-compatible

But +1 as a github admin to go ahead

from cluster-api-provider-nested.

christopherhein avatar christopherhein commented on August 9, 2024

Good catch, thank you, I'll get that fixed up after the branch change.

from cluster-api-provider-nested.

christopherhein avatar christopherhein commented on August 9, 2024

Branch has been changed in the Githuh UI and not is tracking the main branch. https://github.com/kubernetes-sigs/cluster-api-provider-nested/tree/main

from cluster-api-provider-nested.

k8s-ci-robot avatar k8s-ci-robot commented on August 9, 2024

@christopherhein: Closing this issue.

In response to this:

/close
Thanks folks for all your help on this! 🎉
https://groups.google.com/g/kubernetes-sig-cluster-lifecycle/c/Woe731ONmBc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

from cluster-api-provider-nested.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.