Git Product home page Git Product logo

Comments (6)

f0rmiga avatar f0rmiga commented on May 25, 2024

/kind bug

from minibroker.

jhvhs avatar jhvhs commented on May 25, 2024

This has been fixed in the master branch by extracting the port as a variable:
https://github.com/kubernetes-sigs/minibroker/blob/09d7c69266d336b7cdbde9157fbb3e459f3e7656/charts/minibroker/templates/service.yaml#L12

from minibroker.

k8s-ci-robot avatar k8s-ci-robot commented on May 25, 2024

@jhvhs: You can't close an active issue/PR unless you authored it or you are a collaborator.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

from minibroker.

f0rmiga avatar f0rmiga commented on May 25, 2024

@jhvhs thanks for pointing it out. I'll close this issue for now, and maybe we can revisit in the future if we want to do a fancier check and get thinks more automatic.
(Ignore the bot, it got crazy) 😂

from minibroker.

f0rmiga avatar f0rmiga commented on May 25, 2024

/close

from minibroker.

k8s-ci-robot avatar k8s-ci-robot commented on May 25, 2024

@f0rmiga: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

from minibroker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.