Upgrade dockershim to 1.10 about frakti HOT 9 CLOSED

Ok, I see. thank you very much！

from frakti.

I will do it.

from frakti.

Please attention to CRI change: #279

from frakti.

@liyanyanli If you will do this. You can start now, please update the vendor to v1.10.0-rc.1

And later, when 1.10.0 stable is out, update vendor again to latest stable.

from frakti.

@resouer Should we implement dockershim inside frakti and not rely on dockeshim of Kubernetes?

Kubernetes PR: dockershim: remove the use of kubelet's internal API

from frakti.

@liyanyanli dockershim is a workaround, we can keep it for now. In next or next next release, we will not use dockershim and cooperate with containerd instead. You can help with that part if you are interested.

See: https://github.com/cncf/soc#katacontainers-support-for-containerdcri-containerd

from frakti.

@liyanyanli 1.10.0 is out now. Please update the vendor to this stable release if possible.

If you have already finish the work, please just send out and we can update it to 1.10.0 stable later.

from frakti.

Hi, @resouer

I have updated the vendor to 1.10.0. However, the changes made by dockershim make frakti have the following problems when compiling codes and I am trying to solve it.

example:

./frakti.go:113:41: cannot use privilegedRuntime (type *docker.PrivilegedRuntime) as type "k8s.io/frakti/pkg/runtime".RuntimeService in argument to manager.NewFraktiManager:
        *docker.PrivilegedRuntime does not implement "k8s.io/frakti/pkg/runtime".RuntimeService (wrong type for Attach method)
                have Attach(context.Context, *v1alpha2.AttachRequest) (*v1alpha2.AttachResponse, error)
                want Attach(*v1alpha2.AttachRequest) (*v1alpha2.AttachResponse, error)

I have two solutions:

1. Implement dockershim inside frakti

2. Frakti starts dockershim grpc server inside, then connects dockershim's grpc interface

What do you think? Thanks very much！

from frakti.

@liyanyanli Please choose 2.

Just make frakti work like a CRI proxy. Thank you very much!

from frakti.