Git Product home page Git Product logo

Comments (5)

lluunn avatar lluunn commented on August 18, 2024

It's not easy to tell whether a failure in junit file should be ignored or not.

from testing.

jlewi avatar jlewi commented on August 18, 2024

Why does that matter? We only want the ignore to apply to the GitHub status check that prow reports so that we can mark a test as not blocking merges.

The GitHub status check is based on the exit code which we compute in run_e2e_workflow.py based on

  • Did argo workflows succeed
  • Were there any junit files with failures

So our config file would just have to allow us to ignore an argo workflow and junit file when computing the exit code.

Might be nice if we could put some metadata into junit files that would specify which workflow generated them.

from testing.

lluunn avatar lluunn commented on August 18, 2024

Yes we need that metadata to tell whether a junit file can be ignored.

from testing.

stale avatar stale commented on August 18, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in one week if no further activity occurs. Thank you for your contributions.

from testing.

stale avatar stale commented on August 18, 2024

This issue has been closed due to inactivity.

from testing.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.