Git Product home page Git Product logo

Comments (13)

BenHall avatar BenHall commented on July 21, 2024

Thanks for the feedback.

Step2:
GCP: Thanks, we'll get the format updated however, we're reluctant to provide a live read/write access token to a storage bucket as it could be open for abuse. Ideally the example would support Kubernetes persistent volumes so users can decided where the data comes from. This would allow us to train a smaller subset to demonstrate the workflow.

Updated the path, kubelog, typo and path. I don't think the repo existed when we created this so thank you for highlighting.

Step 3: In terms of performance, we'll pre-cache the images once we are happy with which version to use. This will speed up the pod creation as at the moment the images need to be pulled.

Step 4: Thanks! We used kubectl patch to workaround this but pleased it's been added as a ksonnet parameter.

from examples.

jlewi avatar jlewi commented on July 21, 2024

Thanks Ben.

It would probably also be a good idea on the Katacode side specify a commit when cloning GitHub example so it doesn't break unexpectedly. e.g. #84 just moved the ksonnet app.

There are a couple issues on our end that I think need to be fixed

#90 Need to check in vendor directory.

Filed #91 to eliminate the use of GCS.

from examples.

BenHall avatar BenHall commented on July 21, 2024

@jlewi I'm just building a new environment. Which image should I be using for the training and serving? I see the following in the repo:

github-issue-summarization-serving-demo |  
issue-summarization |  
issue-summarization-model |  
issue-summarization-seldon |  
issue-summarization-ui |  
issue-summarization-ui-test

My guess was issue-summarization-seldon for serving but the creation date is March 12, 2018.

The tf-job-issue-summarization image looks to have been deleted?

from examples.

jlewi avatar jlewi commented on July 21, 2024

@BenHall What is image in this context? Docker image or ksonnet component?

@texasmichelle can probably answer better than me what the right component is.

from examples.

BenHall avatar BenHall commented on July 21, 2024

from examples.

jlewi avatar jlewi commented on July 21, 2024

I think you will want the following docker images

  • gcr.io/kubeflow-images-public/issue-summarization:0.1
  • gcr.io/kubeflow-images-public/issue-summarization-ui@sha256:8344fcc0aa47c5923884e14141b91a2615ef765769f200c9974a48d876e78187

Can you explain how the docker images fit into your environment? Is this just to cache them for faster downloads? It looks like in step 2 you tell them to clone our example repository. So I'd expect the images used would be determined by the code in the example.

I just noticed that you are forking kubeflow/kubeflow and have users point to katacoda/kubeflow? Can you explain why you are doing this.

Is the scenario somewhere in GitHub that I can look at. I'd like to understand how this all works to see if there's anything we can do to make it easier to maintain.

For reference I'm basing my answer on what is running in our dev instance.

/cc @texasmichelle

from examples.

BenHall avatar BenHall commented on July 21, 2024

We're seeing the liveness probe failing #106

from examples.

BenHall avatar BenHall commented on July 21, 2024

I just noticed that you are forking kubeflow/kubeflow and have users point to katacoda/kubeflow? Can you explain why you are doing this.

To ensure that we're working against a known release with known versions of the Docker Images. We've also stripped down the repository to make it faster to clone.

All the scenarios content is at https://github.com/katacoda-scenarios/kubeflow-scenarios. We're more than happy for this to be moved to https://github.com/kubeflow/katacoda-scenarios so the community can create additional content :)

from examples.

jlewi avatar jlewi commented on July 21, 2024

Those are good reasons. My intent was only to learn how to better support Katacoda. I don't have a strong oppinion about where the scenarios should live.

from examples.

jlewi avatar jlewi commented on July 21, 2024

@BenHall The changes to support running on PVC are committed.I haven't had a chance yet to go through the complete example E2E yet to make sure it works yet.

/cc @texasmichelle

from examples.

BenHall avatar BenHall commented on July 21, 2024

Thanks @jlewi ! This looks to fix serving, is the plan to do the same for the training too?

from examples.

jlewi avatar jlewi commented on July 21, 2024

@BenHall Training is already done via #98.

So here's roughly how it should go

Training:

  1. Create a PVC to store the data
ks apply ${ENV} -c data-pvc
  • This will create a volume using default storage class
  1. Download the data to the PVC via K8s job
ks apply ${ENV} -c data-downloader
  1. Submit training job using the PVC
ks apply ${ENV} -c tfjob-pvc

Serving

  1. Deploy the model
ks apply ${ENV} -c issue-summarization-model-serving
  • This will deploy a model baked into the container
  1. (Optional) Deploy the webapp
ks apply ${ENV} -c ui

from examples.

stale avatar stale commented on July 21, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

from examples.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.