Add combination of sleepAt options in one resource about kube-green HOT 4 OPEN

Hi @Allure996, interesting idea.
In a first release, I avoided to combine different rules because if the rules are overlapped it's difficult to predict the correct operation of the sleep lifecycle.
It should be interesting to add the feature in a predictable way

from kube-green.

Hi @davidebianchi thanks for your answer.
I'm gonna try to make many sleepInfos overlap, and try to figure out if the right behaviour can be predicted

from kube-green.

@davidebianchi is this still valid? I would like to help on this.
What would be the best way to address a situation where the sleepInfos overlap and, let's say, one tells to wake up when the other tells to put a resource to sleep?

For example:

spec:
  sleepInfoRules:
    - weekdays: "1-5"
      sleepAt: "20:00"
      wakeUpAt: "07:00"
    - weekdays: "3-5"
      sleepAt: "21:00"   
      wakeUpAt: "05:00"

In this scenario, the rules are overlapping and incongruous. We could solve the issue with some assumptions, maybe raising a warning. If these rules have been set, maybe it's been for a mistake, or someone didn't read the previous rules before adding new ones. If so, then the best thing to do would be to merge the rules, and the first one would be the most important one. Kube-green is intended to put resources at sleep, after all, so making the largest rule win should be the correct behaviour.
Otherwise, if these rules are intended, then something is off, and the warning should be enough to notify that they need to be rewritten.

from kube-green.

Hi @gregoriopalama, yes it is still valid. It is not so easy to predict the overlap, so the check is not so easy to add.

We are talking about something similar also here, what do you think? In this way l, it will be possible to handle specific overlap in a straightforward way (but it does not cover all the cases).

from kube-green.