expander text inserted inside self closing tag about jquery-expander HOT 5 CLOSED

I just pushed a change that I think should fix the issue with self-closing tags. Not sure about the header tag, though, since it isn't self-closing. Would you mind testing the latest commit with the header tag and putting up another gist if it's still causing a problem?

Thanks a lot!

from jquery-expander.

Thanks for the fast fix.

It fixed the self closing HR but it has issue with the header:

https://gist.github.com/1423323

from jquery-expander.

Thx for the gist. When I checked it out, I didn't see a problem. It put the "continue reading" link in between the <h3> and </h3> (after "title"), which is where it should go, given the slicePoint. If it had put the link inside an actual tag, mangled it with something like <h3 <span class="..."><a ...>read more</a></span>>, then I'd consider that a bug. But it looks fine where I tested it. Granted, I probably wouldn't want the link to appear as a child element of the <h3> either, but the plugin truncates based on text length, not elements. If you want the "continue reading" link to appear beneath the heading (visually), you could always style it with something like this:

.summary .read-more {
  display: block;
  font-size: 13px;
  font-weight: normal;
}

or something similar.

from jquery-expander.

My perception was that it should be inserted as the last element of the content (the div), not inside the last element inside the div (h3). This way, it would maintain a consistant styling no matter the HTML ending the summary. I guess I will work with CSS to make it work. Thx!

from jquery-expander.

ok. I added an option for you called expandAfterSummary. That should put the "continue reading" stuff after the h3. Cheers!

from jquery-expander.