Git Product home page Git Product logo

Comments (5)

 avatar commented on July 16, 2024

Forgot to add one more:

Stock contracts fixes: A few parts test contracts are missing for the small rover wheel, smaller SRBs and MonoProp engine. In the linked file I also added some extra situations for a few contracts that seemed suitable along with surveys for the Magnetometer, Mystery Goo and Materials Bay.

from kspcommunityfixes.

gotmachine avatar gotmachine commented on July 16, 2024

On the surface, I'm not against config patches as long as they are purely cosmetic or are fixing a really problematic issue.

The stock agencies and missing part manufacturers feel fine to include. Bulkhead profiles are only used for editor part categories, so fine for me, but I concur that using non-existent stock categories (mk0 / mk1 ?) should be be avoided.

The contract patches are leaning a bit too much on the "new features" side to my taste.
This is a Pandora's box that I would prefer to stay closed. There are thousands of ways to make stock configs "better" and as many different opinions as to what changes are actually "better". And I have done enough KSP modding to know that maintaining stock-altering configs is a nightmare when you take the whole modding ecosystem into account.

Another note : please don't use wildcards and use discrete part names everywhere. You never know which random modded part you will accidentally target.

A PR is welcome if you agree to all of this :)

from kspcommunityfixes.

 avatar commented on July 16, 2024

Ok, I'll put that together shortly

Did you have any preference for the directory structure? I can't see any other similar types of fixes so I guess a new folder labelled "Configs" with all this stuff inside, maybe with another subdirectory for the logos

from kspcommunityfixes.

gotmachine avatar gotmachine commented on July 16, 2024

There is currently a Patches directory for mod support patches. I would suggest renaming it ModSupportPatches, and creating a StockConfigsPatches next to it, with an Icons subfolder for the *.png files

from kspcommunityfixes.

 avatar commented on July 16, 2024

thanks, submitted here #64

from kspcommunityfixes.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.