Git Product home page Git Product logo

Comments (15)

soheb-btw avatar soheb-btw commented on June 1, 2024 1

@krishnaacharyaa can I take this issue ?

from wanderlust.

krishnaacharyaa avatar krishnaacharyaa commented on June 1, 2024

@soheb-btw sure
Assigning it to you
Please let us know the time estimation to complete the task

from wanderlust.

soheb-btw avatar soheb-btw commented on June 1, 2024

@krishnaacharyaa I am unable to run recreate the bug on local, sorting seems to be fine on local.
while going through the code I have seen that all the posts that didn't had timeOfPost values in db would give you current time and date when api/posts is called.

git

from wanderlust.

soheb-btw avatar soheb-btw commented on June 1, 2024

Are there any post in db that don't have timeOfPost value ?

from wanderlust.

krishnaacharyaa avatar krishnaacharyaa commented on June 1, 2024

Good catch @soheb-btw , I suspect the problem is with the initial db values which is sample data.json from the readme file ....(ref)
Youu would may be able to reproduce there, if not .... Let me know I'll send the original db's json content....

I suspect that's the issue because I don't see timeofPost value in the sample data

from wanderlust.

soheb-btw avatar soheb-btw commented on June 1, 2024

I did import data from sample_posts.json while setting up the project and then removed all data for testing, both cases I was facing the date issue.

It will be great if you can send the original db's json and then I can debug further and we can know for sure.

from wanderlust.

krishnaacharyaa avatar krishnaacharyaa commented on June 1, 2024

Sure, tomorrow I'll send , please remind me if I forget, either here or in discord, tag master

from wanderlust.

krishnaacharyaa avatar krishnaacharyaa commented on June 1, 2024

Hi @soheb-btw, Please use this for reference, straight from the db, Let me know if you need more support, we can get on a call and resolve
wanderlust.posts.json

from wanderlust.

soheb-btw avatar soheb-btw commented on June 1, 2024

Hi @krishnaacharyaa missing timeOfPost values are creating the issue. It cannot be empty.

from wanderlust.

krishnaacharyaa avatar krishnaacharyaa commented on June 1, 2024

Sure @soheb-btw, thank you for the root cause. So were all do we have to change I guess the sample data and the db data right?

from wanderlust.

soheb-btw avatar soheb-btw commented on June 1, 2024

yes, we need add missing timeOfPost values in both files.

from wanderlust.

soheb-btw avatar soheb-btw commented on June 1, 2024

And one more change is required in /api/posts route, Assuming in All Posts section we are showing latest posts first, its sorting logic is not implemented for the route. I have made the code changes can I make a pull request for this ?

from wanderlust.

krishnaacharyaa avatar krishnaacharyaa commented on June 1, 2024

Sure, can you please follow the contributing guidelines and raise PR. @soheb-btw

from wanderlust.

soheb-btw avatar soheb-btw commented on June 1, 2024

@krishnaacharyaa I have created the pull request from a different account.

from wanderlust.

krishnaacharyaa avatar krishnaacharyaa commented on June 1, 2024

@soheb-btw I have addressed the PR, kindly make the changes and let me know

from wanderlust.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.