module.exports vs export default about callbag-start-with HOT 5 CLOSED

I believe i know what the problem is - gonna prepare a PR to callbag-basics in a moment.

from callbag-start-with.

Could u confirm for me that its causing u problems when using callbag-basics in webpack@4 project?

Temporarily you could try to use callbag-basics-esmodules instead.

from callbag-start-with.

The thing is, I don't use callbag-basics.
I have a react project (using create react app) with webpack 4 and testing with Jest.
Then, I have callbag directory with a package.json with the operators I want to use, and and index.js like the mentioned above. Same as callbag-basics but with all the operators I need.

Everything works fine, importing them as:
import { fromEvent, combine, startWith, map, takeUntil, merge, losslessThrottle, pipe } from 'callbag';

Except that startWith, and the others using ES6, don't work.

I'm looking at the fork using ES6 and it seems overly complicated, with a function to transform everything and requiring babel (otherwise Jest doesn't work). Why not simply use module.exports?

from callbag-start-with.

module.exports is a commonjs thing which is a legacy module format, if you are doing web development you should try to avoid it because the standard ecmascript module syntax (export/import statements) has some traits which can help to make your application bundles smaller

If you have your own reexporting module you should just convert it to this:

export { default as forEach } from 'callbag-for-each'
export { default as fromObs } from 'callbag-from-obs'
export { default as fromIter } from 'callbag-from-iter'
export { default as fromEvent } from 'callbag-from-event'
export { default as fromPromise } from 'callbag-from-promise'
export { default as interval } from 'callbag-interval'
export { default as map } from 'callbag-map'
export { default as scan } from 'callbag-scan'
export { default as flatten } from 'callbag-flatten'
export { default as take } from 'callbag-take'
export { default as skip } from 'callbag-skip'
export { default as filter } from 'callbag-filter'
export { default as merge } from 'callbag-merge'
export { default as concat } from 'callbag-concat'
export { default as combine } from 'callbag-combine'
export { default as share } from 'callbag-share'
export { default as pipe } from 'callbag-pipe'

And I believe it should work for you.

from callbag-start-with.

I changed my index to the new syntax and now both old and new callbags seem to work.
Thanks!

from callbag-start-with.