Git Product home page Git Product logo

Comments (3)

Kelly-ST-HRI avatar Kelly-ST-HRI commented on July 4, 2024

Thanks for your efforts to develop this package @koustav-pal

We've replicated this issue (@kuguit and I) when plotting trans-chromosomal contacts between chromosomes of different sizes (x-axes chromosome was smaller than y-axes). The y_coords therefore did not match the axes limits defined by x_coords or the maximum length of the shorter chromosome.

Error in h(simpleError(msg, call)) :
error in evaluating the argument 'x' in selecting a method for function 'end': subscript contains out-of-bounds indices

I've found the bug causing this and have a working solution which allows:

  • different co-ordinate inputs for each chromosome
  • plotting asymmetric matrices which axes of different sizes
  • inverting the matrix to (optionally) allow plotting the larger chromosome on the x-axis from the same "brick" file

I've tested this solution by modifying the function code and running "source" on this R script to import the update version. I'll submit a pull request with recommended changes.

from hicbricks.

Kelly-ST-HRI avatar Kelly-ST-HRI commented on July 4, 2024

I think this solution will resolve issue #17 as well.

from hicbricks.

Kelly-ST-HRI avatar Kelly-ST-HRI commented on July 4, 2024

I've added these as 2 separate PRs as #25 directly addresses this issue while #26 significantly changes the codebase to allow transpose matrices in the lower triangle to be plotted.

  • different co-ordinate inputs for each chromosome (see PR #25)
  • plotting asymmetric matrices which axes of different sizes (see PR #25)
  • inverting the matrix to (optionally) allow plotting the larger chromosome on the x-axis from the same "brick" file (see PR #26)

from hicbricks.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.