Git Product home page Git Product logo

Comments (2)

kosiakk avatar kosiakk commented on May 20, 2024

Do you think, such approach is reasonable? I have no idea how does it work in JS target.

My original implementation was very simple:

interface TagConsumer<out R> {
     // ...

    // default implementation simply re-throws the exception after closing the tag
    fun onError(exception: Exception) : Unit = throw exception
}

fun <T : Tag> T.visit(block: T.() -> Unit) {
    consumer.onTagStart(this)
    try {
        this.block()
    } catch (err: Exception) {
        consumer.onError(err)
    } finally {
        // all tags are properly closed
        consumer.onTagEnd(this)
    }
}

from kotlinx.html.

cy6erGn0m avatar cy6erGn0m commented on May 20, 2024

The only problem I can see is that if we have a chain of consumers then the error handler in the middle of the chain can only write directly to the delegate rather than pass through the whole chain

pros: we can't get infinite error handling issue
cons: it's not clear what the state the outer consumer will have after writing directly inside of the error handler

from kotlinx.html.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.