Git Product home page Git Product logo

Comments (2)

JakeWharton avatar JakeWharton commented on September 8, 2024 3

In #363 (comment) you say:

For instance, we can support memory mapped files by implementing Sink/Source interfaces, but using file descriptor/MappedByteBuffer/pointer as a buffer, instead of Buffer.

which leads me to believe we want implementation names that reflect the implementation strategy. Otherwise we wouldn't need subtypes at all and Sink and Source could be final classes.

I'm not saying the prefix needs to be Buffered, but something to indicate that it's a Buffer-backed Source and Buffer-backed Sink other than "real" or "impl" would be nice, especially given that other subtypes might exist.

from kotlinx-io.

fzhinkin avatar fzhinkin commented on September 8, 2024

Source and Sink interfaces already imply bufferization, so SourceImpl and SinkImpl could be a better choice.

from kotlinx-io.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.