Return proper `ERRORLEVEL` / `$?` values about awscfncli HOT 5 CLOSED

@GlieseRay plz take a look, it seems the decorator for pretty print stack exceptions hide the error...
This problem may also exists in 2.0 branch.

from awscfncli.

Sure

from awscfncli.

It seems to be a bug in the boto3 exception pretty print handler:

 def boto3_exception_handler(f):
     """Capture and pretty print exceptions"""
 
     @wraps(f)
     def wrapper(*args, **kwargs):
         try:
             return f(*args, **kwargs)
         except (botocore.exceptions.ClientError,
                 botocore.exceptions.WaiterError,
                 botocore.exceptions.ValidationError,
                 botocore.exceptions.ParamValidationError,
                 ) as e:
             click.secho(str(e), fg='red')
+            raise click.Abort
         except ConfigError as e:
             click.secho(str(e), fg='red')
-        except KeyboardInterrupt as e:
-            click.secho('Aborted.', fg='red')
+            raise click.Abort

Click will return exit status 1 when handling Abort exception.

@GlieseRay Please try this on 0.x, I'm testing on v2 branch, which is more complicated since not all commands aborts after caught an exception.

from awscfncli.

I tested on the 0.x version, It's the same problem. I will make a hot fix for that.

from awscfncli.

Hi @mkielar,
Thank you for point this issue out.
We have fixed this issue, and released the fix in 0.5.2. Please upgrade to the latest version.

from awscfncli.