Broken link on About us page about sample-app-net HOT 5 CLOSED

Sure! What @Steve-Fenton says is correct, however, there is another, slightly more elegant solution: to utilize the CultureInfo.CurrentUICulture.Name value in the CustomContentLinkUrlResolver.

The culture is being set in the LocalizedMvcRouteHandler and is then used by the ControllerBase class. It can be therefore used in the same way in the link resolver.

The most-elegant solution is to enrich the ContentLink class in the SDK with a notion of the culture.

Fixed via #62 and filed an issue in the SDK repo.

from sample-app-net.

Should this be fixed in the content, or by adding additional routes?

It could be solved by adding routes to catch all situations where there is no language in the URL - one would be needed for each localized route. Otherwise, the link in the content (which is an en-US page) could be updated to point at the en-US route: /en-us/articles/on-roasts

        routes.MapRoute(
            name: "ArticleNoLang",
            url: "articles/{urlSlug}",
            defaults: new { language = LanguageClient.DEFAULT_LANGUAGE, controller = "Articles", action = "Show", urlSlug = "" }
        );

from sample-app-net.

@JanLenoch could you please comment on that?

from sample-app-net.

Hi guys, I found other broken links in the "Coffee processing techniques" article that lead to "Page not found". Both of them are leading to coffee products: Kenya Gakuyuni AA and Brazil Natural Barra Grande.
I guess the problem might be in the CustomContentLinkUrlResolver.cs since it links products via $"/products/{link.UrlSlug}"; Also, the lang codename doesn't match.

Currently used link: /en-US/products/kenya-gakuyuni-aa
Correct link: /en-us/product/detail/kenya-gakuyuni-aa

See it here: https://dancing-goat-mvc-develop.azurewebsites.net/en-US/products/kenya-gakuyuni-aa

from sample-app-net.

Well spotted, @MartinaFarkasova ! Pushed 47ec62a to finish the fix.

from sample-app-net.