Git Product home page Git Product logo

Comments (8)

Croydon avatar Croydon commented on June 1, 2024 2

@axalon900 I'm sorry for your frustration. In the Conan Center Index we have an every increasing amount of activity and pretty much always > 100 open PRs at the same time. The core contributors have by now strong routines and go through a lot of PRs every single day. Through all of these we also have established standards which needs to be meet in order to be able to maintain all of this in the long term. If something seems unclear or illogical, feel free to ask about it in your PR, in new issues or in Slack 😃

from fire-hpp.

Croydon avatar Croydon commented on June 1, 2024 2

@kongaskristjan Yes, all done

Thanks 😃

from fire-hpp.

Croydon avatar Croydon commented on June 1, 2024 1

You could add a MIT LICENSE file to the root and a second 0BSD LICENSE file to the examples sub-directory. I think that should cover all concerns

Btw, do you have a specific package manager in mind?

Someone is currently packaging fire-hpp for the C/C++ package manager Conan:
conan-io/conan-center-index#3405

from fire-hpp.

kongaskristjan avatar kongaskristjan commented on June 1, 2024

A problem with having a licence file is that I currently use two different licences. For the library itself, I use Boost, as I still want a basic protection from copying the project and claiming it's the copier's work. Examples, however, are meant to be blatantly copied into whatever project without any notice, and thus I use 0BSD. One option is to have everything under Boost and simply hope that people don't feel guilty about copying examples.

Btw, do you have a specific package manager in mind?

Edit: library uses Boost, not MIT

from fire-hpp.

eigenwhat avatar eigenwhat commented on June 1, 2024

Yeah, that's me. Hello again.

I'm about ready to just close that PR and just wait for 0.2 (or just forget it entirely) because this has frankly been an infuriating saga. I feel bad enough having pushed this project to accept the structural and CMake changes to help make packaging go nicely, but then on top of that to get a bunch of reviews from people who did nothing but open up this page, look at some dates, and then start countermanding everything with no explanation like this is all one big careless mistake? Yeah, nope.

I'm sorry, I didn't mean for this to be so much trouble.

from fire-hpp.

eigenwhat avatar eigenwhat commented on June 1, 2024

Sorry, needed to blow off a little steam, which is hard when you also want to remain polite. 😰 I had already pushed for several changes here in order to enable my PR and to have that not be good enough because of what sounds like reviewers' own personal taste has me pretty bitter.

I do agree with the suggestion though. If the issue is that the examples are licensed differently, having one license file in the root and another in the examples folder should work.

from fire-hpp.

kongaskristjan avatar kongaskristjan commented on June 1, 2024

Done in d7fe466.

Added Boost and 0BSD licences to / and /examples/ respectively (I erroneously said MIT and 0BSD in a previous comment). I think this was a necessary addition anyway, as some files right now don't have a licence at all.

Can I close the issue?

from fire-hpp.

eigenwhat avatar eigenwhat commented on June 1, 2024

@Croydon It's all good. I really should have just not hit submit and slept on it. I would've deleted the comment but it's probably in everyone's email so I figured I'll "reap what I've sown". ;) I commented in the CCI PR that I'll just close and wait for 0.2 since @kongaskristjan says it should be ready soon, and that would eliminate most points of contention.

from fire-hpp.

Related Issues (6)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.