Git Product home page Git Product logo

Comments (13)

christophlingg avatar christophlingg commented on August 17, 2024

Yohan told me this is something we should try out to see which option has the best tradeoff between performance and storage size.

from photon.

karussell avatar karussell commented on August 17, 2024

Yes, sure. Maybe there is even a better, less hacky way of doing this. E.g. like the cross_fields approach and still using nedge gram where it would just boost berlin erlanger* more than berlin* erlangen somehow.

from photon.

karussell avatar karussell commented on August 17, 2024

These docs seems to be more current + better example

from photon.

christophlingg avatar christophlingg commented on August 17, 2024

btw. the cross_fields approach might make the collector field obsolete. we introduced it to have equal idf for all fields. But I haven't been aware of this feature so far...

@yohanboniface , we could even give different scores to each field, not only distinguish between name and collector. And much more important, we aren't forced to copy each time the default fields into the language specific collectors. this opens the door for multilingual support of all languages in osm as we save a lot of storage size...

from photon.

karussell avatar karussell commented on August 17, 2024

Yes, kind of recent feature but we'll have to try if this solves our problem.

from photon.

yohanboniface avatar yohanboniface commented on August 17, 2024

cross_fields can't work with fuzzy atm.

from photon.

yohanboniface avatar yohanboniface commented on August 17, 2024

btw, wordending is not the hotest topic if you have time to spend on search logic. Two things we are on:

On the search logic part, the more up to date branch is https://github.com/komoot/photon/tree/positivescoring

Also: add tests! :)

from photon.

karussell avatar karussell commented on August 17, 2024

Probably we also need a mailing list. Should I create a google group or one at openstreetmap?

from photon.

karussell avatar karussell commented on August 17, 2024

Re tests: do you mean creating Java test suite (master) or adding others? I could go to create Java test stuff

from photon.

yohanboniface avatar yohanboniface commented on August 17, 2024

Probably we also need a mailing list. Should I create a google group or one at openstreetmap?

I'd go for [email protected], to keep the argument open instead of having a mailing dedicated for photon, then one for pelias, etc.

Re tests: do you mean creating Java test suite (master) or adding others? I could go to create Java test stuff

I was referring to search tests, like those, but all tests are good ;) BTW, Christoph already started on the Java side I think.

from photon.

karussell avatar karussell commented on August 17, 2024

Hmmh, 'geocoding' mainly sends issues. I would prefer a list dedicated to discussion where nominatim and photon would be okay but there are similar projects like e.g. GraphHopper and OSRM which have separate lists ;)

I was referring to search tests, like those, but all tests are good ;) BTW, Christoph already started on the Java side I think.

Ok, we still need some more lightweight test cases in Java I think. I've create a PR for that. See e.g. this

from photon.

christophlingg avatar christophlingg commented on August 17, 2024

I like the idea of a mailing list and would go for a photon specific mailing list as geocoding is super generic. Do you know who we can approach for setting up a new osm mailing list?

Great commit, peter!

from photon.

karussell avatar karussell commented on August 17, 2024

@christophlingg I'll give you the mail via mail ;)

from photon.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.