Git Product home page Git Product logo

Comments (4)

kolbdog323 avatar kolbdog323 commented on July 29, 2024

An example is if episode 6 doesnt have a thumbnail for the episdoe on tmdb the custom scraper wont scrape an image from imdb for the same episdoe you have to use the imdbtv scraper first then custom scraper to keep the image. Its very annoying.

from mediaelch.

bugwelle avatar bugwelle commented on July 29, 2024

Thanks for reporting! I will have a look soon.

from mediaelch.

kolbdog323 avatar kolbdog323 commented on July 29, 2024

Any luck on this as well. Also I will try the nightly build tomorrow to try out the missing overview and see if it's fixed.

from mediaelch.

bugwelle avatar bugwelle commented on July 29, 2024

Thank you very much for reporting this issue. I've found few other bugs (one crash) that I've now also fixed.

Your bug was a copy&paste error. I looked at the TV show settings when loading episodes. The fix is trivial:

--- a/src/scrapers/tv_show/custom/CustomEpisodeScrapeJob.cpp
+++ b/src/scrapers/tv_show/custom/CustomEpisodeScrapeJob.cpp
@@ -46,7 +46,7 @@ void CustomEpisodeScrapeJob::onTmdbLoaded(EpisodeScrapeJob* job)
     copyDetailsToEpisode(episode(), job->episode(), job->config().details);
     job->deleteLater();
 
-    const QStringList scrapersToUse = m_customConfig.scraperForShowDetails.values();
+    const QStringList scrapersToUse = m_customConfig.scraperForEpisodeDetails.values();
     const bool loadImdb = episode().imdbId().isValid() && scrapersToUse.contains(ImdbTv::ID);
 
     m_loadCounter = 1;

It will be fixed shortly. Note that there are currently issues with our Nightly-build pipeline for Windows. It may take another day for a Nightly to appear.

from mediaelch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.