Git Product home page Git Product logo

Comments (10)

monolifed avatar monolifed commented on August 27, 2024 1

Right.
https://github.com/monolifed/tiny-regex-c/tree/quantifier

from tiny-regex-c.

kokke avatar kokke commented on August 27, 2024

Hi @violet701

The quantifier-operator ({number-of-matches}, {min-matches, max-matches) is not supported. I think that's the problem you're experiencing.

As a small hack, maybe you can replace \d{15} with \d+ or \d\d\d\d\d\d\d\d\d\d\d\d\d\d\d...?

from tiny-regex-c.

monolifed avatar monolifed commented on August 27, 2024

Adding the matching function doesn't seem hard

static int matchquantifier(regex_t p, regex_t* pattern, const char* text, int min, int max)
{
  max -= min;
  while (min > 0 && *text && matchone(p, *text++))
  {
    min--;
  }
  if (min > 0)
    return 0;
  do
  {
    if (matchpattern(pattern, text))
      return 1;
    max--;
  }
  while (max > 0 && *text && matchone(p, *text++));

  return 0;
}

But you'd probably need another array to store mins and maxs

from tiny-regex-c.

kokke avatar kokke commented on August 27, 2024

Hi @monolifed

Maybe you could extract the min/max limits from the pattern before calling the matching function, avoiding the need to add extra variables holding the min/max values?

from tiny-regex-c.

kokke avatar kokke commented on August 27, 2024

Wow that looks really promising @monolifed :) i will review the code later today / this evening.

I expect i will merge your PR #22 as well :)

from tiny-regex-c.

kokke avatar kokke commented on August 27, 2024

@monolifed

I have run a few tests on your quantifier-branch, and I really like it so far.

If you make another PR adding the quantifier functionality (or add it to #22), I will merge it.

from tiny-regex-c.

violet701 avatar violet701 commented on August 27, 2024

oh, it's GREAT!!!

from tiny-regex-c.

kokke avatar kokke commented on August 27, 2024

Hey @monolifed - will you make a PR with the quantifier-addition? I think I somehow dropped this on the floor.

I am not sure how to review which additions were made besides the addition of the matchquantifier-function. Maybe you have a better recollection/overview?

from tiny-regex-c.

monolifed avatar monolifed commented on August 27, 2024

I don't really remember well

from tiny-regex-c.

kokke avatar kokke commented on August 27, 2024

😆

I'll try and see if I can get time to clone the branch, pull from master and diff against it. That should do it no? I don't think that branch is any unmergeable changes behind.

from tiny-regex-c.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.