Add better support for yaml lists about git2consul-go HOT 10 CLOSED

So, I'm kinda an idiot. Consul doesn't support lists, it's key/value. It supports lists in the manner that the value can be raw json or yaml. So if you want a list you have to store it as such. So just do:

test: |
- blah
- blah
- blah

If the code was modified, it would have to store it that way anyway .. May be kinda a pain if you already have existing yaml code, but we are starting from scratch so we're just gonna use this method.

from git2consul-go.

@Garagoth thanks opening this issue. Would you be willing to submit a pull request for this enhancement request?

from git2consul-go.

@Garagoth Have you encountered this error under other conditions?

We have a large config repo that does not have yaml lists as far as we know. We get the same error and have not yet been able to locate which file(s) could have an issue.

FWIW, we are trying to migrate from the breser/git2consul project and all of the files are yaml.

from git2consul-go.

@seanmalloy I am not fluent in go, so my pull request would be of poor quality I am afraid. I would need to learn a bit for this.

@stevenscg so far only with arrays of things that are not maps. Check for constructs like this as well:
key: [v1, v2, v3]
This is a valid array in yaml as well.

from git2consul-go.

@Garagoth Thanks. I'll try to look into it more later.

@seanmalloy Do you happen to know if there is a way to see which file is causing a problem when we see this error message? Maybe by increasing the log level?

from git2consul-go.

@Garagoth Thanks for that pattern! We found that we have 1 line like that in 1 file in each tree. I'll try removing it for now as a workaround.

from git2consul-go.

Any update on this? I'm seeing the same behaviour.

from git2consul-go.

@replicant0wnz unfortunately we're very short staffed and won't get to it any time soon. A pull request for this would be greatly appreciated. :)

from git2consul-go.

It sounds to me that there's an easy way to get this working, without code modifications. Should we close this PR or leave it open in the hopes somebody will tackle it someday?

from git2consul-go.

Well, it'll still crash if it receives a list. I'd say better sanity checking at a minimum. I may be able to tackle it later, but my golang knowledge is minimal.

from git2consul-go.