Comments (4)
@kimulaco
What's src/js/*
in this case?
If it's the JavaScript for the docs I must say I'm against this, I feel like the src
directory should only contain the source files for water.css
itself, not accompanying documentation fluff.
But you're right that we need separate places for compiled docs and source docs if we want a build chain there. Alternatives would be:
- Use
docs/*
as source directory and compile to eitherdist/docs/
ordocs/dist/
. This way it'd be clear that the docs in the respectivedist
folder are "just" compiled distribution files and one mustn't edit them. Downside is that some tools like GitHub pages expectdocs/
to contain the actual documentation, not uncompiled source files – but I don't see us leaving Netlify and migrating back to GitHub Pages anytime soon, so I don't think that's too important. - Use
src/docs/*
as source dir, compile todocs/
. This way we got our documentation files withinsrc/
which I'm against in general, but since the files are in a folder calleddocs/
instead of src directories with generic names likejs/
, I think I'd be fine with that, as this way they can't be confused as part of the actualwater.css
source. Problem with this is that now the intuitive and instantly-visibledocs/
folder is NOT to the place for our contributors to edit the documentation.
TL;DR: I'm in favor of keeping a clear separation between the source of water.css
itself and its documentation, the best way to achieve this can be discussed.
from water.css.
@kognise @kylejrp @jonaskuske
I saw some issues and thought that I needed to move files other than docs files.(#89 #84 etc...)
We will also need to change the src directory to make a JavaScript build environment.
And that's related to moving docs files.
I think the following directory is common. (Those that have not been changed are omitted.)
now
├ dist/*.css
├ src/
│ ├ builds/*.css
│ ├ parts/*.css
│ └ *.css
├ index.html
├ scripts.js
└ ...
after
├ dist/*.css
├ docs/
│ ├ index.html
│ ├ css/*.css <= Needed here too?
│ └ js/*.js
├ src/
│ ├ css/
│ │ ├ builds/*.css
│ │ ├ parts/*.css
│ │ └ *.css
│ └ js/*.js
└ ...
Please let us know if you have any ideas for your opinion or response policy!
from water.css.
I considered these as one project and had the idea of saving the pre-build JavaScript resources used for the document in src/js/*
.
However, as @jonaskuske says, I agree to separate the resources of the library itself and the documentation!!
from water.css.
This was fixed in #90 which has been merged. <3
from water.css.
Related Issues (20)
- content list HOT 4
- Profile section HOT 5
- provide support for styling html meter and progress tags
- Any unofficial successor going on? HOT 5
- Radio buttons are cut off HOT 2
- Feature request add hover to the button HOT 7
- Feature request: dialog box shadow (dark mode) HOT 2
- Adding dark mode and improved UI HOT 6
- Issues being spammed with "Assign this to me" comments? HOT 4
- Ugly thing on text areas HOT 3
- This repository is not currently being maintained HOT 4
- Missing Header and Footer HOT 7
- The header of the page can be improved to a great extend..
- The header of the page can be designed to a great extend and needs some margin in the bottom HOT 2
- Add a custom 404 error page HOT 9
- Possible improvements in UI
- Fix the broken URL HOT 3
- Enhancement : Back To Top Button
- Irregular size of SUBMIT and RESET button
- The inline quotation element "q", should not be formatted the same as the "blockquote" element.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from water.css.