Git Product home page Git Product logo

Comments (4)

jonaskuske avatar jonaskuske commented on May 22, 2024 2

@kimulaco
What's src/js/* in this case?
If it's the JavaScript for the docs I must say I'm against this, I feel like the src directory should only contain the source files for water.css itself, not accompanying documentation fluff.

But you're right that we need separate places for compiled docs and source docs if we want a build chain there. Alternatives would be:

  • Use docs/* as source directory and compile to either dist/docs/ or docs/dist/. This way it'd be clear that the docs in the respective dist folder are "just" compiled distribution files and one mustn't edit them. Downside is that some tools like GitHub pages expect docs/ to contain the actual documentation, not uncompiled source files – but I don't see us leaving Netlify and migrating back to GitHub Pages anytime soon, so I don't think that's too important.
  • Use src/docs/* as source dir, compile to docs/. This way we got our documentation files within src/ which I'm against in general, but since the files are in a folder called docs/ instead of src directories with generic names like js/, I think I'd be fine with that, as this way they can't be confused as part of the actual water.css source. Problem with this is that now the intuitive and instantly-visible docs/ folder is NOT to the place for our contributors to edit the documentation.

TL;DR: I'm in favor of keeping a clear separation between the source of water.css itself and its documentation, the best way to achieve this can be discussed.

from water.css.

kimulaco avatar kimulaco commented on May 22, 2024

@kognise @kylejrp @jonaskuske
I saw some issues and thought that I needed to move files other than docs files.(#89 #84 etc...)
We will also need to change the src directory to make a JavaScript build environment.
And that's related to moving docs files.

I think the following directory is common. (Those that have not been changed are omitted.)

now

├ dist/*.css
├ src/
│  ├ builds/*.css
│  ├ parts/*.css
│  └ *.css
├ index.html
├ scripts.js
└ ...

after

├ dist/*.css
├ docs/
│ ├ index.html
│ ├ css/*.css  <= Needed here too?
│ └ js/*.js
├ src/
│ ├ css/
│ │  ├ builds/*.css
│ │  ├ parts/*.css
│ │  └ *.css
│ └ js/*.js
└ ...

Please let us know if you have any ideas for your opinion or response policy!

from water.css.

kimulaco avatar kimulaco commented on May 22, 2024

I considered these as one project and had the idea of saving the pre-build JavaScript resources used for the document in src/js/*.
However, as @jonaskuske says, I agree to separate the resources of the library itself and the documentation!!

from water.css.

kognise avatar kognise commented on May 22, 2024

This was fixed in #90 which has been merged. <3

from water.css.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.