Comments (3)
I thought about this too for a while, so thanks for starting that discussion!
My thought was to go with a combination of ESLint, Stylelint and prettier (integrated through eslint-plugin-prettier
and stylelint-prettier
respectively) to catch mistakes (ESLint, Stylelint) and enforce common formatting guidelines (prettier).
We would integrate this through husky
and lint-staged
with out Git setup. This way, whenever a Contributor commits something, all the files that are selected for the commit will be linted & fixed automatically, so we can be sure that everything in the repo will adhere to our code guidelines, but contributors don't have to configure linting and the respective Editor integrations themselves (if they don't want to). They can format code they write however they want, but once they check it in, it will be formatted to match our rules.
I like prettier because it's very opinionated (so you don't have to discuss style preferences) and because it can format pretty much anything: CSS, JS, Markdown, JSON...
But only if everyone here can live with prettier's formatting rules, of course.
from water.css.
I'm on board for this. I like the idea of an opinionated default configuration that we don't customize.
Having it work with editors and during commits is a great idea and we should make sure that's supported.
I'm curious what @kognise thinks. You can propose a pull request but I'll want @kognise to approve.
from water.css.
Sounds like a great idea! Sorry for taking so long - I'll make a PR. I love Standard, but @JanSchneider1 mentioned that forcing semicolons might be more beginner friendly. I don't agree or disagree, but we should consider this.
from water.css.
Related Issues (20)
- content list HOT 4
- Profile section HOT 5
- provide support for styling html meter and progress tags
- Any unofficial successor going on? HOT 5
- Radio buttons are cut off HOT 2
- Feature request add hover to the button HOT 7
- Feature request: dialog box shadow (dark mode) HOT 2
- Adding dark mode and improved UI HOT 6
- Issues being spammed with "Assign this to me" comments? HOT 4
- Ugly thing on text areas HOT 3
- This repository is not currently being maintained HOT 4
- Missing Header and Footer HOT 7
- The header of the page can be improved to a great extend..
- The header of the page can be designed to a great extend and needs some margin in the bottom HOT 2
- Add a custom 404 error page HOT 9
- Possible improvements in UI
- Fix the broken URL HOT 3
- Enhancement : Back To Top Button
- Irregular size of SUBMIT and RESET button
- The inline quotation element "q", should not be formatted the same as the "blockquote" element.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from water.css.