Git Product home page Git Product logo

Comments (21)

koddr avatar koddr commented on July 17, 2024 8

@EvanZ oh, strange. Peer dependencies will be install with update to vue-goodshare 0.9.2.

But ok, just install all dependencies manually:

$ npm install css-loader sass-loader node-sass vue-style-loader --save-dev

from vue-goodshare.

lggwettmann avatar lggwettmann commented on July 17, 2024 2

Yeah GoodShare's install was great, but I run into 1000 problems now trying to make the Sass loader to run.. Would be great if those Sass dependencies a) would be gone and b) could be mentioned in the docs.

from vue-goodshare.

koddr avatar koddr commented on July 17, 2024 1

Fix at 0.9.2

from vue-goodshare.

koddr avatar koddr commented on July 17, 2024 1

@lggwettmann I make it ASAP.

Your PR is welcome :D

from vue-goodshare.

lggwettmann avatar lggwettmann commented on July 17, 2024 1

Yes, still relevant. Still waiting 😉

from vue-goodshare.

koddr avatar koddr commented on July 17, 2024

Oh, yep. I'm forget to add dependencies for SCSS.
Thanks for reporting!

from vue-goodshare.

EvanZ avatar EvanZ commented on July 17, 2024

Sorry, tried using 0.9.2 and still getting peer dependency errors.

ERROR in ./~/vue-goodshare/src/providers/Line.vue
Module not found: Error: Can't resolve 'scss-loader' in '/Users/***/***/node_modules/vue-goodshare/src/providers'
 @ ./~/vue-goodshare/src/providers/Line.vue 3:0-242
 @ ./~/babel-loader/lib!./~/vue-loader/lib/selector.js?type=script&index=0!./~/vue-goodshare/src/VueGoodshare.vue
 @ ./~/vue-goodshare/src/VueGoodshare.vue
 @ ./~/babel-loader/lib!./~/vue-loader/lib/selector.js?type=script&index=0!./src/components/**.vue
 @ ./src/components/**.vue
 @ ./src/routes.js
 @ ./src/main.js
 @ multi (webpack)-dev-server/client?http://localhost:8080 webpack/hot/dev-server ./src/main.js

npm WARN [email protected] requires a peer of css-loader@>=0.28.0 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of sass-loader@>=6.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of node-sass@>=4.6.0 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of vue-style-loader@>=3.0.0 but none is installed. You must install peer dependencies yourself.


from vue-goodshare.

EvanZ avatar EvanZ commented on July 17, 2024

That does not fix the error. Any other idea what might be going on?

from vue-goodshare.

koddr avatar koddr commented on July 17, 2024

@EvanZ could you please run our example on your computer for understand «where is the problem»? Follow this instructions and write to me if something went wrong.

from vue-goodshare.

EvanZ avatar EvanZ commented on July 17, 2024

I was able to run that and it worked. I thought maybe I needed to upgrade to webpack 3, so I tried that. Still no luck getting it to work with my project though. Just keep getting the same scss-loader errors.

from vue-goodshare.

koddr avatar koddr commented on July 17, 2024

Hmm.. can you share your Webpack config?

I'm using this Webpack 3 config for my projects, btw.

from vue-goodshare.

EvanZ avatar EvanZ commented on July 17, 2024

Here you go:

https://gist.github.com/EvanZ/37848cd428772437c18d50848ca10419

from vue-goodshare.

koddr avatar koddr commented on July 17, 2024

@EvanZ yes, thx.

Try to add:

  {
    test: /\.vue$/,
    loader: "vue-loader",
    options: {
      loaders: {
        scss: 'vue-style-loader!css-loader!sass-loader' // <-- this line
      }
    }
  },

...

plugins: [
  // this block
  new webpack.LoaderOptionsPlugin({
    vue: {
      loaders: {
        scss: 'style!css!sass'
      }
    }
  })
]

from vue-goodshare.

EvanZ avatar EvanZ commented on July 17, 2024

Thanks, first part is easy. But second part I'm not sure where to put that. I see this, but it is for production and I am running in dev currently:

if (process.env.NODE_ENV === 'production') {
  module.exports.devtool = '#source-map'
  // http://vue-loader.vuejs.org/en/workflow/production.html
  module.exports.plugins = (module.exports.plugins || []).concat([
    new webpack.DefinePlugin({
      'process.env': {
        NODE_ENV: '"production"'
      }
    }),
    new webpack.optimize.UglifyJsPlugin({
      sourceMap: true,
      compress: {
        warnings: false
      }
    }),
    new webpack.LoaderOptionsPlugin({
      minimize: true
    })
  ])
}

from vue-goodshare.

koddr avatar koddr commented on July 17, 2024

I’m planning to drop Fontello iconic font and replace them with inline SVG. This can help, if dependencies doesn’t install or working correctly.

Future 1.0.0 release, I think.

from vue-goodshare.

vlahde avatar vlahde commented on July 17, 2024

I am having this same issue in version 0.9.3

from vue-goodshare.

lggwettmann avatar lggwettmann commented on July 17, 2024

Thanks @koddr - highly appreciate it.

Unfortunately, I have no clue how to fix it or remove the dependency.

from vue-goodshare.

stale avatar stale commented on July 17, 2024

👋 Hello. Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Thank you for your contributions.

from vue-goodshare.

stale avatar stale commented on July 17, 2024

👋 Hello. Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Thank you for your contributions.

from vue-goodshare.

stale avatar stale commented on July 17, 2024

⚡️ This issue has been automatically closed because it has not had recent activity.

from vue-goodshare.

lggwettmann avatar lggwettmann commented on July 17, 2024

Btw, yes, still relevant if anyone knows how to fix this.

from vue-goodshare.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.