Comments (21)
@EvanZ oh, strange. Peer dependencies will be install with update to vue-goodshare
0.9.2.
But ok, just install all dependencies manually:
$ npm install css-loader sass-loader node-sass vue-style-loader --save-dev
from vue-goodshare.
Yeah GoodShare's install was great, but I run into 1000 problems now trying to make the Sass loader to run.. Would be great if those Sass dependencies a) would be gone and b) could be mentioned in the docs.
from vue-goodshare.
Fix at 0.9.2
from vue-goodshare.
@lggwettmann I make it ASAP.
Your PR is welcome :D
from vue-goodshare.
Yes, still relevant. Still waiting 😉
from vue-goodshare.
Oh, yep. I'm forget to add dependencies for SCSS.
Thanks for reporting!
from vue-goodshare.
Sorry, tried using 0.9.2 and still getting peer dependency errors.
ERROR in ./~/vue-goodshare/src/providers/Line.vue
Module not found: Error: Can't resolve 'scss-loader' in '/Users/***/***/node_modules/vue-goodshare/src/providers'
@ ./~/vue-goodshare/src/providers/Line.vue 3:0-242
@ ./~/babel-loader/lib!./~/vue-loader/lib/selector.js?type=script&index=0!./~/vue-goodshare/src/VueGoodshare.vue
@ ./~/vue-goodshare/src/VueGoodshare.vue
@ ./~/babel-loader/lib!./~/vue-loader/lib/selector.js?type=script&index=0!./src/components/**.vue
@ ./src/components/**.vue
@ ./src/routes.js
@ ./src/main.js
@ multi (webpack)-dev-server/client?http://localhost:8080 webpack/hot/dev-server ./src/main.js
npm WARN [email protected] requires a peer of css-loader@>=0.28.0 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of sass-loader@>=6.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of node-sass@>=4.6.0 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of vue-style-loader@>=3.0.0 but none is installed. You must install peer dependencies yourself.
from vue-goodshare.
That does not fix the error. Any other idea what might be going on?
from vue-goodshare.
@EvanZ could you please run our example on your computer for understand «where is the problem»? Follow this instructions and write to me if something went wrong.
from vue-goodshare.
I was able to run that and it worked. I thought maybe I needed to upgrade to webpack 3, so I tried that. Still no luck getting it to work with my project though. Just keep getting the same scss-loader
errors.
from vue-goodshare.
Hmm.. can you share your Webpack config?
I'm using this Webpack 3 config for my projects, btw.
from vue-goodshare.
Here you go:
https://gist.github.com/EvanZ/37848cd428772437c18d50848ca10419
from vue-goodshare.
@EvanZ yes, thx.
Try to add:
{
test: /\.vue$/,
loader: "vue-loader",
options: {
loaders: {
scss: 'vue-style-loader!css-loader!sass-loader' // <-- this line
}
}
},
...
plugins: [
// this block
new webpack.LoaderOptionsPlugin({
vue: {
loaders: {
scss: 'style!css!sass'
}
}
})
]
from vue-goodshare.
Thanks, first part is easy. But second part I'm not sure where to put that. I see this, but it is for production and I am running in dev currently:
if (process.env.NODE_ENV === 'production') {
module.exports.devtool = '#source-map'
// http://vue-loader.vuejs.org/en/workflow/production.html
module.exports.plugins = (module.exports.plugins || []).concat([
new webpack.DefinePlugin({
'process.env': {
NODE_ENV: '"production"'
}
}),
new webpack.optimize.UglifyJsPlugin({
sourceMap: true,
compress: {
warnings: false
}
}),
new webpack.LoaderOptionsPlugin({
minimize: true
})
])
}
from vue-goodshare.
I’m planning to drop Fontello iconic font and replace them with inline SVG. This can help, if dependencies doesn’t install or working correctly.
Future 1.0.0 release, I think.
from vue-goodshare.
I am having this same issue in version 0.9.3
from vue-goodshare.
Thanks @koddr - highly appreciate it.
Unfortunately, I have no clue how to fix it or remove the dependency.
from vue-goodshare.
👋 Hello. Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Thank you for your contributions.
from vue-goodshare.
👋 Hello. Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Thank you for your contributions.
from vue-goodshare.
⚡️ This issue has been automatically closed because it has not had recent activity.
from vue-goodshare.
Btw, yes, still relevant if anyone knows how to fix this.
from vue-goodshare.
Related Issues (20)
- How to use it with nuxt js HOT 2
- Vue 3 compile error HOT 3
- Should Add Instagram social network HOT 4
- add new social network HOT 4
- Add props to set target while opening new window HOT 4
- VueCompilerError: v-model can only be used on <input>, <textarea> and <select> elements HOT 8
- Need.... WhatsApp, Messenger HOT 3
- Vue 3 Composite API- Missing Declaration File HOT 2
- New X logo for old twitter logo HOT 1
- your server seems hacked HOT 2
- Please add support for events like @click HOT 3
- Mobile icons are too small HOT 3
- Using with nuxt.js HOT 10
- sms is missing from project? HOT 2
- Whatsapp Share link not found on web.whatsapp.com HOT 2
- Whatsapp Share link not found on Mobile HOT 8
- button line has shared error HOT 5
- GoodShare for Nuxt HOT 2
- Odnoklassniki share button opens deprecated page HOT 3
- WhatsApp Share link incorrect HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vue-goodshare.