Please Respect The License about zui HOT 4 CLOSED

@shagu You are absolutely right, I've been slacking with the credits.. This project started out as a personal little modified project and as I implemented more stuff I forgot to give proper credits, and for that I'm sorry. It was never my intention to even share this at the beginning, but then I figured that maybe there's someone out there who would like to use it. You can see in the history of the .toc file that your name always has been there under "Author" but I agree that it wasn't enough.

I took a look at mikebrady's github and made a section for heritage and a special thank you in the ReadMe. You are the greatest addon developer I know and I promise you that I have never tried or had any intention to take credits for any of the work that derived from you.

from zui.

@shagu I'm sorry that you feel that way, I've thought that I'd given you credits in more places than that. Your name is under author in the .toc file too but I guess I should make it more clear exactly what's been taken or heavily inspired from your addons. I will go over all the files and add proper credits. I will talk to you again once I've done that and see what you think. Shagu you are a god at this and you are one of my greatest inspiration, if you're not happy afterwards, I'll just delete those parts.

from zui.

Thanks for f8f36fa

It wasn't my intention having you add comments into every file though. It would just have been great to have a section somewhere in the readme, where you tell about where the origin of the project was, that it started as a fork or whatever. Also name the addon projects/authors where you took code from is most likely what other authors expect you to do aswell. A good example from a project (unrelated to addons) that started as a fork and became more and more independent would be https://github.com/mikebrady/shairport-sync#heritage

You might can get some inspiration from how he did it, maybe paired with a "Thanks to" section to mention the others ;)

Cheers

from zui.

Thank you very much. It looks good now.

This project started out as a personal little modified project and as I implemented more stuff I forgot to give proper credits, and for that I'm sorry.

I understand, happens.

I think the first sentences of the README can be removed as they're duplicates now. 😉

from zui.