Conversation: second argument of `ItemInterface::addChild()` is the URI about knpmenu HOT 5 CLOSED

But people who want to use routes (and many Sf2 users will) would have to use $menu->addChild('Fooooo', null, array('route' => 'homepage')) which is also ugly. Using a separate parameter for the uri makes it really ugly when it is omitted.

from knpmenu.

I really don't like the route, routeParameters and routeAbsolute options - and yes, I realize that they were in my original version :), but we've come a long way since then. I think that regardless of the framework, people are used to generating a URL in a certain way. We should have them use that same method when creating a menu and not cloud things:

// symfony
$menu->addChild('Fooooo', $router->generateUrl('homepage'));

// Silex
$menu->addChild('Fooooo', $app['url_generator']->generateUrl('homepage'));

What do you think?

from knpmenu.

this was the way it was done in the previous version (as the MenuItem was not router-aware) but this was an issue for the createFromNode feature as an entity cannot have access to the router, thus having to have a router-aware factory in this place. Once we have it, why supporting the route for one method and not the other ?

from knpmenu.

ah damn, you're right - and the createFromNode is really cool. Ok, let's leave it, though I'm still torn on how we should document it. If you have a basic route, route => 'homepage' is cool. But as soon as you have route parameters, I think it starts to get cloudy, but maybe not.

Thoughts on that?

from knpmenu.

I don't see another way than asking to give the route parameters. The user would have to do the same when using the generator directly.

from knpmenu.