Comments (5)
Hey, @cseickel
I implemented some functionality we discussed here in this PR: #9.
I would appreciate if you look at it / try it out / give any kind of feedback whatsoever.
Thanks :D
from nvim-dbee.
Hi @cseickel,
thanks for the suggestions.
All are valid points in my opinion.
- and 2. are pretty straight forward, whereas 3. would need a bit of thinking.
To add on top of 3.:
- add a simple file for project local configs (just a list of connections.
- environment variables seem the most straight forward so I preffer it over integrating pass (although I wouldn't say it's completely out of the question - maybe sometime in the future?).
- I think we go with the first syntax option you mentioned (
${{}}
) and just inject env vars once connecting to the db. That would probably be enough for now. - I like the concept with proprietary secrets you created, but I fear it could get a bit confusing for new users - I need sit on it a bit.
That's an approximate TODO for this issue, I would love to hear your thoughts about it.
Other than that I'll start working on that as soon as I have some extra time.
from nvim-dbee.
I think we go with the first syntax option you mentioned (${{}}) and just inject env vars once connecting to the db. That would probably be enough for now.
I agree that seems like the simplest way to go about it, and users can do a lot to roll their own solutions that inject env variables. One thing that may trip you up there is if you are checking the variables from an external (go) process, will it see the same env variables that are in nvim's process? If not then it might not work out.
For # 3, on further thought it would probably be a maintenance nightmare. It might be simpler to just integrate your own secret storage with an encrypted file. I'm sure there are go libraries you can use, and the input could just be an interactive prompt if the password was not set in the config.
from nvim-dbee.
One thing that may trip you up there is if you are checking the variables from an external (go) process, will it see the same env variables that are in nvim's process? If not then it might not work out.
I thought about that, yeah - one can also have a plugin that messes with vim.env
jn lua - so we would need to read env in lua in my opinion - I'd still like to test go first - it might even work.
I also thought about an encrypted file - sounds like a good Idea to me!
from nvim-dbee.
closed with #9
from nvim-dbee.
Related Issues (20)
- CSV yanks only part of the data HOT 2
- dbee not found after add the plugin by lazy HOT 4
- [Feature] Nvim Tree integration HOT 3
- Health command not functioning properly
- Dbee ui toggle throws error HOT 10
- Can't see error output for failed queries? HOT 1
- Some postgresql statements don't have output
- [postgres] too many clients already HOT 2
- Feature request: database helpers HOT 1
- [bigquery] Cannot finish fetching results with BigQuery resource HOT 1
- Feature request: disconnect from active connection HOT 4
- [Bug] Doc issue; Duplicate "DefaultLayout" HOT 3
- [Help wanted] "dbee" command not found HOT 6
- show column number on `relativenumber` options HOT 2
- [postgres] no output when executing some statements inside of transaction block HOT 3
- Doesn't work with packer and LunarVim HOT 2
- Clickhouse Nullable columns in result window HOT 2
- timeout for executing queries HOT 1
- PostgreSQL commands not working HOT 3
- DrawerUI is broken on windows HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nvim-dbee.