Git Product home page Git Product logo

Comments (4)

knausb avatar knausb commented on June 3, 2024

Hi Zhian,

You may not be familiar with the vcfR object, but I'm not very familiar with the genlight object. So I appreciate the example you posted. The devel branch has been updated to add this information to the genlight object. I'd appreciate if you could validate that this is what you were expecting. There is an example of using this function in the vignette 'converting_data'. Be forewarned that the example did not include interesting info for locNames, but I do think its implemented correctly.

Thank you!

from vcfr.

zkamvar avatar zkamvar commented on June 3, 2024

I will check this and close it once validated.

Thank you for the work, Brian!

from vcfr.

zkamvar avatar zkamvar commented on June 3, 2024

Hi Brian,

I tried following the vignette "converting_data.Rmd", but I ran into trouble because the pinfsc50 package didn't exist on my machine. I installed it, followed the steps and it worked. There are no locus names, however because the ID column of the fix slot contains all NAs

from vcfr.

knausb avatar knausb commented on June 3, 2024

Hi Zhian,

Variant callers, such as SAMTools, FreeBayes or the GATK's haplotype caller, typically do not populate ID slot of vcf format files. This field is typically encoded as '.' in the vcf file and is converted to 'NA' in the vcfR object. This is a field from a valid vcf file and I feel I've handled it in an R appropriate manner. See this link for the vcf definition.

http://samtools.github.io/hts-specs/

The ID field will be populated from other sources (e.g., someone included it in dbSNP). When these annotations are included in the ID field they should be included in the vcfR@fix[,'ID'] field which should be inserted into locNames(x) by vcfR2genlight. The present example simply doesn't illustrate this well.

Thanks for closing this!
Brian

from vcfr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.