Comments (6)
IMO, we should aim this as first thing after v0.1.
from client.
This is completed, thanks @maximilien !
from client.
So I took at pass at this when I was doing the plugin
command. It's doable but requires the following changes:
-
move some types from
root.go
to acommon
package to avoid import cycles, e.g., this common package for one of my plugin branches -
sweeping change to each command to use the common package above, e.g., this plugins example
Bottom line is that it's not hard to do just requires agreement and one swoop change.
If you guys want this before milestone 1 I could do this this week, while you all asleep in Europe. I'll add this to the agenda tomorrow as a low priority issue.
/cc @sixolet @cppforlife
from client.
@maximilien Is this something you are already on ? I'm asking while I'm working on #14 I also want to split up and separate the commands better (as I want to use some some package scoped vars which shouldn't 'pollute' whole "commands").
I agree that we need a "common" package which should hold the shared code, e.g. KnParams
. I also believe that KnParams
should be an interface defined in common and an implementation in the root "commands" package.
As I'm on it as well, I would be happy also to take over this task if you don't have a chance to come to is soonish. (there are some other subtle things like how to register subcommands and also the human-readable printers now reference commands directly).
In any case, we should tackle this issue very soon.
from client.
OK as per discussion today. Let me submit something today. I am sure you guys will have lots of feedback. More soon.
from client.
Done in #145
from client.
Related Issues (20)
- Update plugin development docs HOT 5
- Can not get my broker through `kn broker list` HOT 6
- [48h Knative] KServe plugin HOT 4
- Align GVK format accepted by `--channel` flag HOT 12
- Flaky E2E test: e2e/TestDomain - create domain with TLS HOT 9
- Wrong version for kn create kafka channel HOT 7
- Add integration tests for all command usage examples in the binary HOT 5
- [48h Knative] Annotation and Label profiles HOT 1
- [48h Knative] Color output HOT 3
- [48h Knative] UX Evaluation HOT 10
- [48h Knative] Kamelet Sinks HOT 2
- [48h Knative] Command Usage Example Integration Testing POC HOT 3
- [48h Knative] Improved Logging HOT 7
- [48h Knative] Good first issues HOT 3
- Cmd `kn service wait` doesn't end on ready ksvc as expected
- CLI: `--user` option does not work as expected
- Add missing completion support for fish and PowerShell shells
- Error: fork/exec /usr/local/bin/kn-func: exec format error HOT 1
- Proposal: Fold back in client-pkg to Go submodule HOT 10
- kn service export doesn't work with traffic splits HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from client.