Git Product home page Git Product logo

Comments (2)

Rican7 avatar Rican7 commented on May 18, 2024

This is expected behavior. Klein's an intelligent router that allows you to have "named" parameters in the URL. If you're proposed behavior were the default, someone would be able to overwrite the URL-matched parameter, which would be "sketchy" and unexpected.

The design is that the named params take precedence. If you're finding that you have a collision, simply rename your url-matched param, or rename your expected GET/POST param. :)

from klein.php.

chriso avatar chriso commented on May 18, 2024

$_REQUEST already works in this way in regards to whether variables are taken from $_GET, $_POST or $_COOKIE - see the variables_order config directive.

If parameters from the query string or request body were allowed to override named parameters then type restrictions could be bypassed, e.g. a /users/[i:id] route vs. /users/0?id=0%3B%20DROP%20TABLE%20users 😲

Klein could be modified so that it doesn't mutate the underlying $_REQUEST array but I think as an extra security precaution it's ok for now.

from klein.php.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.