Git Product home page Git Product logo

Comments (6)

ben-j69 avatar ben-j69 commented on June 9, 2024

@Mazorius thanks for the suggestion, it would not be hard to make them public but do you see any use case of this public constants for our plugin users ?

from hidden-secrets-gradle-plugin.

Mazorius avatar Mazorius commented on June 9, 2024

If you write a custom plugin which applies your plugin or you want to extend or reconfigure the your created tasks.

I think currently a developer needs to hope you will not change the names in the future as they declare this names as strings instead of using your well defined constants.

For example I used the SonarQube plugin in my projects an need to say ... with the sonarqube plugin do this.
Much better would it to use a constant so SonarQube can change their plugin name and I do not care as developer. Because I am using the constant which they will change ;-)

from hidden-secrets-gradle-plugin.

ben-j69 avatar ben-j69 commented on June 9, 2024

Thanks @Mazorius , done in #20 to be able to use them in tests, if you can check the code please ;)

from hidden-secrets-gradle-plugin.

Mazorius avatar Mazorius commented on June 9, 2024

Looks good ;-)

from hidden-secrets-gradle-plugin.

Mazorius avatar Mazorius commented on June 9, 2024

Maybe you will check the constants content in tests so that changing them will result in test failures?

from hidden-secrets-gradle-plugin.

ben-j69 avatar ben-j69 commented on June 9, 2024

@Mazorius I agree with you, done in #20

So I close this issue ;)

Thanks

from hidden-secrets-gradle-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.