Comments (2)
slavafomin
commented on June 2, 2024
I can confirm this issue. The content of the Retry-After header is incorrect. It should contain seconds, while in practice it contains milliseconds. I think we should convert millis to seconds here right before we return the result to the guard.
from nestjs-throttler-storage-redis.
kkoomen
commented on June 2, 2024
Hi. Thanks a lot for noticing this, unfortunately this became a problem during the big rewrite last time. The tests did check for a number, but not a specific number. I've modified tests to make sure the secs are beings checked to make sure this won't happen again in the future.
I've just released this immediately under v0.3.2 on NPM.
from nestjs-throttler-storage-redis.
Related Issues (20)
- That is a bad idea to use Redis SCAN command, it works not like you expects... HOT 6
- Request flooding bypasses rate limit to some extend HOT 6
- unable to implement custom guard HOT 1
- WRONGTYPE Operation against a key holding the wrong kind of value HOT 8
- Redis storage does is not working - no errors HOT 3
- Dynamically update config values of limiter HOT 1
- Redis connection kept open after application shutdown
- @nestjs/throttler v5 ttl unit changed from second to milisecond HOT 4
- connecting with forRootAsync doesn't work HOT 11
- Not working for limit greater than 10_000 HOT 5
- nest 8 compatibility HOT 1
- Problems with Redis storage HOT 1
- Support redis cluster HOT 14
- Issue Fixed in 322 Still Exists HOT 2
- `Maximum call stack size exceeded` error while e2e test my NestJS app HOT 3
- update ioredis to v5
- suggestion: uninstall @types/ioredis
- Update peer dependencies on @nestjs/common and @nestjs/throttler to latest version compatible versions HOT 4
- connect aws ElastiCache with seperate read and write HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nestjs-throttler-storage-redis.