Fixed Bugs and Made Changes about react-native-device-display HOT 6 CLOSED

Tried your fix - worked like a charm! Thank you!
I've made a pull request to the repo with your suggested changes, so everyone can enjoy your fix!

from react-native-device-display.

Awesome, thanks.

from react-native-device-display.

Hi, I've tried master (as these changes aren't versioned yet) and it works fine when I develop and reload the app, but not on when I launch the app for the first time.

I can't really figure out what the issue is, it appears that [UIScreen mainScreen].applicationFrame returns the wrong data (and now I understand the crazy swap of width and height).

However, googling around, it seems that UIDeviceOrientationDidChangeNotification is deprecated in favor of viewWillTransitionToSize:
http://stackoverflow.com/questions/26069874/what-is-the-right-way-to-handle-orientation-changes-in-ios-8
Maybe it's worth exploring the new style?

from react-native-device-display.

Hi again,

I did additional tests, and I believe that viewWillTransitionToSize is the right way to go. It also works on slide over (multitasking) on ipad/ios9.

All I did to test is to implement a viewcontroller, and use it in my AppDelegate:

- (void)viewWillTransitionToSize:(CGSize)size withTransitionCoordinator:(id <UIViewControllerTransitionCoordinator>)coordinator
{
  UIDeviceOrientation deviceOrientation = [[UIDevice currentDevice] orientation];
  NSDictionary *dimensions = @{ @"width": @(size.width), @"height": @(size.height), @"orientation": @(deviceOrientation) };

  NSLog(@"%@", dimensions);

  [super viewWillTransitionToSize:size withTransitionCoordinator:coordinator];
}

Unfortunately I have no idea how to send an event to js, here I need your help :)

from react-native-device-display.

Last comment for today, promised. I made it work with a hack: I created the controller, sent a notification, and used this module to listen to my own notification instead of UIDeviceOrientationDidChangeNotification.

I asked on SO, if I can find a better/cleaner solution, I'll post a PR:
http://stackoverflow.com/questions/33469009/implement-native-controller-in-react-native

from react-native-device-display.

Merged. #16

from react-native-device-display.