Git Product home page Git Product logo

Comments (12)

a-rodriguez avatar a-rodriguez commented on August 25, 2024 2

I for one would like to see this released, it would help a complete noob like me. I do appreciate everyone effort and understand the complexity.

from homebridge-broadlink-rm.

masterfordev avatar masterfordev commented on August 25, 2024 1

@mitch7391 i know.. haha That is why I preferred not to continue with the development.

from homebridge-broadlink-rm.

kiwi-cam avatar kiwi-cam commented on August 25, 2024

Hi @mitch7391

I did look at this a while ago. To be honest... it looked like it could create a lot of work for basically no reward. It's on my to do list but pretty far down the priorities.

It also requires another item that is on my list, Plugin Setting GUI. With the multiple nested arrays in our configuration this gets very complex and I couldn't get my head around it. If someone else can build a config.schema.json I'd be more than happy to include it - it looks like the tools they link have improved since I last looked at it.

from homebridge-broadlink-rm.

mitch7391 avatar mitch7391 commented on August 25, 2024

Oh yeah, I see what you mean! Definitely above my skill level to help too haha I wonder if another user might have the time or skills to help out :)

Another plug-in I recently tried was mqttthings that has the config.schema.json and appears you can do more complicated sorts of config. It looked like you can do a basic config from there and further advance the config from the actual config editor page. Don’t know if that is worth checking out? If not then all good :)

from homebridge-broadlink-rm.

masterfordev avatar masterfordev commented on August 25, 2024

I've been trying to create an interface but it's impossible, in order to do so it's necessary to re-organize the types of accessories.

Maybe something like that:
Accessories.type.properties

from homebridge-broadlink-rm.

Edsonytic avatar Edsonytic commented on August 25, 2024

I have been trying to create a valid config schema for the past day and have found that as @masterfordev says it would seem like a perfect fit would need other changes in the code.
However @mitch7391's mention of homebridge-mqttthing having only partial support got me thinking that maybe an incremental approach could be taken with the first versions only serving to get the user started with the config block for the plugin and if it proves to be of benefit considering wether to make changes.

I do think that it would help a lot with people that don't check the documentation and examples properly and have issues because of an incorrectly formatted config block.

I have just re-started my attempt with this approach in mind, but maybe it could be better to create a development branch specific to this issue so those of us who are interested can pool our efforts?

from homebridge-broadlink-rm.

masterfordev avatar masterfordev commented on August 25, 2024

@Edsonytic

I was trying to create a "basic" configuration with an schema. And I succeeded, with the debug options, hide lear-code, name and more. The problem is that if you click on save changes, it overwrites the whole section in the config file and deletes everything you have entered manually.

So I preferred not to do more because it would cause a lot of problems. Unless there is a way that I can just "modify" the values of the scheme and not overwrite the whole section.

This is what I did:
Screenshot

from homebridge-broadlink-rm.

Edsonytic avatar Edsonytic commented on August 25, 2024

from homebridge-broadlink-rm.

masterfordev avatar masterfordev commented on August 25, 2024

But if they decide to use the interface again after making their manual accessory settings, those changes would be removed. I don't see that convenient, I don't know what think @kiwi-cam about that. I think it would cause more problems than it solves.

from homebridge-broadlink-rm.

mitch7391 avatar mitch7391 commented on August 25, 2024

That overwriting of the config is definitely a major problem. For me testing out homebridge-mqttthing and not realising that until a few attempts was very frustrating; have to create a manual accessory configuration again due one change I tried to make from the schema... If that happened to me with all the accessories I have in this plug-in... Well I don’t want to think about that lol

from homebridge-broadlink-rm.

mitch7391 avatar mitch7391 commented on August 25, 2024

Yeah I would say that unless that hurdle could be overcome somehow, then this would cause more issues than it would solve haha...

from homebridge-broadlink-rm.

stale avatar stale commented on August 25, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

from homebridge-broadlink-rm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.