What happened to 'go' ? about kitchenplan HOT 11 CLOSED

@roderik, @thomasmeeus ?

from kitchenplan.

i think a go script for windows could still be added and use the new way of using kitchenplan.

it's a pity that your code could not be shared before we did this cleanup (for osx it's way simpler and the separation of kitchenplan from configfiles is real improvement) so it could be included from the start.

The "old" version is still available in the version2 branch (https://github.com/kitchenplan/kitchenplan/tree/version2)

from kitchenplan.

Thanks for responding!

If I'd been more careful to do all my porting work at home on personal equipment on my own time I might have been able to avoid this. I also underestimated the enthusiasm of the kitchenplan community and overestimated the amount of time it would take to go through the internal approval process. All big mistakes on my part!

I'll see if rebasing against version2 is any less of a horror show. To be clear, I'm not just adding "go.bat" - it's a nearly complete rewrite of Kitchenplan which abstracts out platforms (and includes OS X, Linux and Windows implementations) and cookbook resolvers (and includes Librarian and Berkshelf implementations). Only the config file parsing code is the same.

If you guys weren't interested I was considering releasing it as its own project, actually... though I have been in the OSS world long enough to consider that a last resort - I hate project fragmentation!

Here's hoping all goes well and I have something cleaned up and ready for you early next week.

from kitchenplan.

... Okay, I think I see what's going on. I've cherry-picked the relevant version2 commits and I have something that should be compatible with version2, yet adds all of the features I've mentioned above.

I also have the beginnings of a proper unit testing suite for all this library code. I'll see about adding tests while I wait for final approval.

from kitchenplan.

Is this related to your code changes? https://twitter.com/DisneyChefQs/status/456944032972013568

from kitchenplan.

That's it. I'm supposed to put on some kind of company disclaimer in the comments on all the files I've added but they haven't given me the exact language yet. Once that's done, I can push the code.

from kitchenplan.

@leftathome i have to admit i'm a bit concerned about you releasing a fork under your own corp with an increased version number. I would rather look at a pull request so we can figure out a way to merge it. But without any code to look at that's quite hard 😄 I also would live to see the presentation that was given at ChefConf!

from kitchenplan.

@roderik Oh, I see what you're saying. The reason I "released" at that URL (which, as of this writing, isn't even live) is that it took longer than I anticipated to get all the legal and technical approvals. My pull request will come out of that repository once the company disclaimer / copyright notice is posted. The only other delay I see is if there's a problem getting the unit test suite running in Travis-CI.

My branch is currently rebased off of the version 2 branch, as you recommended, and should merge cleanly. As for what version it actually is ... well, I don't much care what version you call it, but I was basing it off of semantic versioning - it's definitely not a minor or patch update. :)

We didn't officially record our presentation at ChefConf, unfortunately. I'm checking to see if we can post the deck online somewhere. Or send me an e-mail and I'll see what I can do...

from kitchenplan.

@leftathome ok great!

from kitchenplan.

And in regard to the versions, it's my hope to get your changes to the version2 branch and the new smooth way of splitting the configs from the script (works really great btw, just redid my computer last week) merged together somehow and that would indeed be a version 3 release 😄

from kitchenplan.

See #88 for the gory details...

from kitchenplan.