Lost ability to search across multiple fields after upgrade to 1.1.2 about tanker HOT 5 CLOSED

I actually did some changes on how the search query is produced in order to introduce the snippeting. I have been corresponding with the index tank ceo and working directly with their devs. I will look into this in the following days. Sorry its been kinda crazy lately. I have a pretty good idea on how to fix this.

I will also add more integration tests to cover this issue.

from tanker.

Awesome. I actually have another issue related to snippets. It seems that when returning a collection, the snippets for the last item in the collection appear to overwrite the previous item's snippets. I'll look more into this and probably write some integration tests to replicate the issue.

I also had a look at the integration tests and the coverage looks pretty slim around snippets. I'd like to use this gem for an app that's due to release within a few weeks. So I'm definitely interested in helping work thru any remaining bugs. I plan to give the code a closer read this afternoon.

If at all possible, keep me in the loop as you continue to discuss plans with the index tank people so that I have a good idea where best to direct my efforts.

Thanks again!

from tanker.

Yes for sure!

First stop is making tanker more stable and have more tests that make it less brittle across big changes.

A quick roadmap for now would be (in that order):

Conditional indexing (per instance and per attribute)
Categories and faceting
Category filtering
Better dsl for Variables and functions
Clean dsl for GEO
JS powered realtime search helpers :D

Thats it for now but Index Tank is awesome to work with and I hope to add mor things to help on leveraging Index Tank as a data visualization analytics source not just a search service.

from tanker.

I have confirmed that snippets are in fact being overwritten with a failing integration test.

Incidentally, I'm in the process of overhauling the integration tests in order to better catch some of these issues during future releases. Along the way, I've uncovered a few serious problems with how the tests were written which explains why these bugs slipped thru the cracks. I'll give more details in the pull request once I'm finished poking around.

As always, thanks for the awesome gem.

from tanker.

I am closing this issue because your last awesome contribution fixed this !

Thanks again!

from tanker.