A couple of bugs I found in the loader.c about ktx-software HOT 7 CLOSED

I really wonder how nobody got on these before.Like,no one loads anything but textures 2D ? :P

from ktx-software.

Thank you for the bug report. Please send me a PR with the fixes.

really wonder how nobody got on these before.Like,no one loads anything but textures 2D ? :P

The GL loadtests only test 2D textures but it is surprising nobody else spotted these errors. I'd be happy to accept a PR with additional tests.

The tests for the new Vulkan loader (WIP over on https://github.com/msc-/KTX) include array and cube texture tests.

from ktx-software.

from ktx-software.

I can drop the whole loader.c here if you wish.

If you have a fix for #1, please drop those lines here. No need for the whole thing.

from ktx-software.

`
texnameUser = pTexture && *pTexture;
if (texnameUser) {
texname = *pTexture;
} else {
glGenTextures(1, &texname);
}

/* load as 2D texture if 1D textures are not supported */
if (texinfo.textureDimensions == 1 &&
    ((texinfo.compressed && (pfGlCompressedTexImage1D == NULL)) ||
     (!texinfo.compressed && (pfGlTexImage1D == NULL))))
{
    texinfo.textureDimensions = 2;
    texinfo.glTarget = GL_TEXTURE_2D;
    header.pixelHeight = 1;
}

if (header.numberOfArrayElements > 0)
{
    if (texinfo.glTarget == GL_TEXTURE_1D)
    {
        texinfo.glTarget = GL_TEXTURE_1D_ARRAY_EXT;
    }
    else if (texinfo.glTarget == GL_TEXTURE_2D)
    {
        texinfo.glTarget = GL_TEXTURE_2D_ARRAY;
    }
    else if (texinfo.glTarget == GL_TEXTURE_CUBE_MAP)
    {
        texinfo.glTarget = GL_TEXTURE_CUBE_MAP_ARRAY;
    }
    else
    {
        /* No API for 3D arrays yet */
        return KTX_UNSUPPORTED_TEXTURE_TYPE;
    }
    texinfo.textureDimensions++;
}
errorTmp = glGetError();
assert(errorTmp == 0);
glBindTexture(texinfo.glTarget, texname);
errorTmp = glGetError();
assert(errorTmp == 0);

`
Before that,the glBindTexture was at the top.

from ktx-software.

This is fixed in the new code in branch incoming. I'll backport the fix to master soon.

from ktx-software.

Item #1 is now fixed in master. #2 was already fixed in master.

Both are also fixed in incoming.

from ktx-software.