Comments (6)
MarkCallow
commented on July 20, 2024
I'll consider it. Please send a pull request with a proposal. Remember that the guard define must be unlikely to be used by a user of the KTX library. That is why is has a non-compliant leading '_'.
from ktx-software.
elfring
commented on July 20, 2024
There are other possibilities to improve the affected source code.
- How do you think about to add a prefix?
- Would you like to make include guards unique by appending a kind of UUID?
from ktx-software.
MarkCallow
commented on July 20, 2024
I think appending a UUID is the answer. Any prefix still risks conflicting with a user program.
from ktx-software.
elfring
commented on July 20, 2024
Are you going to delete the leading underscore in affected identifiers?
from ktx-software.
MarkCallow
commented on July 20, 2024
Yes, as that is the non-compliant part. Please submit a pull request with what you think is a good solution.
from ktx-software.
MarkCallow
commented on July 20, 2024
This has been fixed. Closing.
from ktx-software.
Related Issues (20)
- Conversion to ktx2 using toktx of a jpg image is resulting into a black ktx2 texture HOT 8
- KTX 2.0 texture format unable to GLupload | DEBUG_OUTPUT printing error on ktx 1.0 | typo in the documentation HOT 5
- compile fail linux HOT 2
- After converting the image to ktx format using "ktx create" I get a texture that is not similar to the input image. HOT 1
- pyktx docs use of `_` prefix conflicts with GitHub Pages' Jekyll. HOT 2
- ktx create --depth x have no use HOT 11
- libglvnd-devel conflict when installing KTX-Software-4.2.1 x86_64 RPM on Fedora with a pre-installed SDL2 HOT 5
- Neither `create` nor `encode` write the codec choice in KTXwriterScParams HOT 4
- using libKTX on Linux when linking report errors on Threads::Threads HOT 9
- When compiling under Windows, it prompts unix2dos: command not found. HOT 5
- Error using ktx create --assign-primaries none HOT 6
- [OS X] There are no include files. HOT 3
- Feature request: Tool to create combined image by gathering channels from input images HOT 6
- OptionsSingleInSingleOut does not warn or give error on excess positional parameters
- ktx transcode does not remove existing KTXwriterScParams metadata HOT 4
- Update code for KTX-Spec changes HOT 2
- createDFDPackedPadded creates DFD with bits and padding in the wrong order
- Support R16G16_S10_5_NV format
- Allow A8B8G8R8 PACK32 formats
- Loading KTX1 and KTX2 file on Linux/OpenGL 4.3 leads to weird error if not luch the program with sudo HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ktx-software.