Git Product home page Git Product logo

Comments (10)

MarkCallow avatar MarkCallow commented on July 20, 2024

I noticed these when working on ktx2ktx2. It caused me to add a feature to drop such invalid metadata or optionally rewrite it during the conversion. I don't have a good way to fix these .ktx files as I don't have the original images. (I would really like to get those for the Yokohama cubemap). I will have to resort to a binary editor I suppose.

Are you up for creating a PR with the fixes?

from ktx-software.

sevmeyer avatar sevmeyer commented on July 20, 2024

No problem. I found the incorrect keys while working on a simple KTX inspection tool, which also can be used to fix the files. The real challenge was to review the changes in Git.

On this subject, I'm working on a repository with custom KTX test files, including files with errors. Hopefully, that will be a useful contribution to the pool of test data for KTX tools.

from ktx-software.

MarkCallow avatar MarkCallow commented on July 20, 2024

IIRC, I created metalplate* and not4* using PVRTexTool. Maybe it is the guilty party in the other images too, which I found on the net. I just checked and found "KTXOrientation" in the binary. It is indeed the culprit.

from ktx-software.

MarkCallow avatar MarkCallow commented on July 20, 2024

I reported this to Imagination:

https://forums.imgtec.com/t/pvrtextool-setting-incorrect-ktx-metadata/3024

from ktx-software.

jherico avatar jherico commented on July 20, 2024

@MarkCallow The original yokohama images are these I believe:
http://www.humus.name/Textures/Yokohama3.zip

They're JPG, but they appear to be higher quality than the KTX existing compressed versions (i.e. no terrible banding in the sky)

from ktx-software.

jherico avatar jherico commented on July 20, 2024

Here's the ktx version: https://s3.amazonaws.com/Oculus/cubemap_yokohama_rgba32.zip

from ktx-software.

jherico avatar jherico commented on July 20, 2024

oops... looks like I accidentally found the culprit for the original bug.... my cubemap was created using PVRTexTool, and it appears to have put the incorrect KTXOrientation name in. I've posted in their forum about the issue here: https://forums.imgtec.com/t/incorrect-invalid-ktx-key-value-data/3047

from ktx-software.

MarkCallow avatar MarkCallow commented on July 20, 2024

Thanks for the pointer to the Yokohama cubemaps. If I have time next week I'll try to create a Basis compressed .ktx2. I'd like to make new .ktx files of the ETC2, ASTC & BC3 versions as well.

As I noted in an earlier comment, I posted in the imgtec forum as well. There has been no response.

from ktx-software.

jherico avatar jherico commented on July 20, 2024

Whoops... should have read the whole thread I guess.

from ktx-software.

MarkCallow avatar MarkCallow commented on July 20, 2024

No worry. The extra post in the forum will show multiple people are interested in a fix.

from ktx-software.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.