Git Product home page Git Product logo

Comments (2)

timiimit avatar timiimit commented on June 13, 2024

Maybe it would be helpful to describe the compile & link approach I've been using.

Pseudocode:

hlsl = read_file()
for each of 5 shader stages
{
    stage = new TShader(stages[i]);
    stage->setStringsWithLengthsAndNames(hlsl)
    stage->setEntryPoint(entryPointNames[i])
    success = stage->parse()
    entrypoints = stage->getIntermediate()->getNumEntryPoints()
    errors = stage->getIntermediate()->getNumErrors()
    if (entrypoints != 1 || entrypoints != 0)
        success = false

    if (success)
        program.addShader(stage)
}
program.link()

It should be noted that hlsl source might not contain entrypoints of all shader stages. So I cannot just do addShader for all shader stages, because then linking will fail with errors such as this:

Linked geometry stage:

WARNING: Linking geometry stage: Entry point not found
ERROR: Linking geometry stage: At least one shader must specify an input layout primitive
ERROR: Linking geometry stage: At least one shader must specify an output layout primitive
ERROR: Linking geometry stage: At least one shader must specify a layout(max_vertices = value)

from glslang.

timiimit avatar timiimit commented on June 13, 2024

Right after writing previous comment, I thought of a different approach. Now I tried to create separate TProgram for each TShader. So that I can compile and link each stage individually.

But it seems that now I encountered another problem where Domain shader stage (EShLangTessEvaluation) does not need an entrypoint to compile and link. So both compilation and linking is successful and spirv is generated. Also spirv-cross seems to be able to convert it to glsl. But it only generates this

#version 460

void main()
{
}

This glsl then fails to link for real in OpenGL when being used as a tesselation evaluation shader with error message:

Tessellation evaluation info
----------------------------
Internal error: assembly compile error for tessellation evaluation shader at offset 228:
-- error message --
line 10, column 1:  error: program missing TESS_MODE declaration
-- internal assembly text --
!!NVtep5.0
OPTION NV_internal;
OPTION NV_bindless_texture;
# cgc version 3.4.0001, build date Feb 22 2024
# command line args: 
#vendor NVIDIA Corporation
#version 3.4.0.1 COP Build Date Feb 22 2024
#profile gp5tp
#program main
TEMP T;
END
# 0 instructions, 0 R-regs

Since I have never used this stage I don't really know what is and isn't considered valid. As a temporary workaround I added

if (currentShaderStage == EShLangTessEvaluation && spirv.size() < 512)
    continue;

after glslang::GlslangToSpv because it seems to always produce small spirv.

from glslang.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.