Comments (2)
Seems like a decent idea, although I wonder if it'd just be better to log an error message/warning if spaces are found in the keys.
Obviously, spaces are syntactically allowed in JavaScript objects, and yet I've never seen a scalable or open-source proiect every use keys with spaces (let alone spaces at end or beginning). So maybe a warning message + automatic trim is a better approach as it tells you the spaces are there (instead of just always trimming them without ever mentioning anything)
from runtime-env-cra.
Hi @seanblonien I'm so sorry for the delay, I open the PR #17 .
Should be amazing if you can check or review the PR.
from runtime-env-cra.
Related Issues (15)
- It causes an issue during the build time of production. HOT 4
- Uncaught SyntaxError: Unexpected token '<' HOT 1
- Add documentation for usage in testing HOT 5
- Support comments in .env file HOT 2
- Unable to build a docker image if environment are not present HOT 1
- Using CMD[...] breaks NGINX default entrypoint HOT 3
- using runtime-env-cra in React Hello World Application not working HOT 1
- "Property does not exist on type Window in TypeScript"
- Runtime environment variables which may have secrets is exposed in developer consoler HOT 7
- Suggestion: Add ability to merge .env file values with process.env values HOT 1
- Does not generate the file runtime-env.js HOT 6
- Usage in Production HOT 7
- Not setting NODE_ENV to development deactivates --env-file flag HOT 3
- Usage on S3 or other static file server? HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from runtime-env-cra.