Poor accuracy on timer interrupt frequency or interval. about mbed_rpi_pico_timerinterrupt HOT 18 CLOSED

You can't use inaccurate millis() to measure TimerInterrupt accuracy.

To make some sense, you have to, at least, use accurate enough Oscilloscope

Check ISR_16_Timers_Array_Complex on RaspberryPi Pico and/or use ISR_16_Timers_Array_Complex example for better way to measure the accuracy without Scope

from mbed_rpi_pico_timerinterrupt.

Well, I have a scope, so I'll check it that way. I haven't found mills() to be inaccurate though.

from mbed_rpi_pico_timerinterrupt.

By the way, the code in the loop doesn't measure the period. That's measured in the interrupt. The loop just prints out a snapshot of the most recent period.

from mbed_rpi_pico_timerinterrupt.

Okay, I just checked it with a scope. It's off by 2%. I have the interrupt at 20 kHz, and I toggle an output pin every time through. One cycle of that output pin takes 102 us. It should be 100 us.

Here's the modified code with the scope trigger.

void TimerHandler(uint alarm_num) // Frequency version
{
  static int zz = 0;
  static int prev_millis = 0;
  int new_millis;

  TIMER_ISR_START(alarm_num);
 
  zz++;
  digitalWrite(18, zz & 1);    // This pin should go high every 100 us, but it takes 102.

  if(zz >= TIMER_FREQ_HZ) {
    zz = 0;
    new_millis = millis();
    delta = new_millis - prev_millis;
    prev_millis = new_millis;
  }

  TIMER_ISR_END(alarm_num);
}

from mbed_rpi_pico_timerinterrupt.

I checked it at some other frequencies. At 50 kHz, I get 42 us instead of 40, so it's off by 2 us.
At 10 kHz I get 202 us instead of 200, so also 2 us. It looks like there's a constant 2 us error, regardless of frequency.

from mbed_rpi_pico_timerinterrupt.

Hi @pixpop

OK, the issue is convincing now. I'll have a look soon when having time.

Can you help try using the previous cores, such as v2.7.2, and v3.0.0 to see if the issue caused by the library or the cores.

Thanks,

from mbed_rpi_pico_timerinterrupt.

The bug still shows as closed. Can you reopen it?

from mbed_rpi_pico_timerinterrupt.

Can you also try RPI_PICO_TimerInterrupt library, especially have a look at Enable fixed timing between timer calls (vs fixed time btw. end of timer call and next call as implemented) #3 to see if related.

The previous problem caused by weird syntax introduced by RPi-Pico SDK, possibly confusing the Arduino MBED core people ???

I'll fix the severe bug to let users to set fixed timing between timer calls by using the negative delay

4.2.14.4.2. add_repeating_timer_us
static bool add_repeating_timer_us (int64_t delay_us,
repeating_timer_callback_t callback,
void *user_data,
repeating_timer_t *out)
Add a repeating timer that is called repeatedly at the specified interval in microseconds
Generally the callback is called as soon as possible after the time specified from an IRQ handler on the core of the
default alarm pool (generally core 0). If the callback is in the past or happens before the alarm setup could be
completed, then this method will optionally call the callback itself and then return a return code to indicate that the
target time has passed.
Parameters
• delay_us the repeat delay in microseconds; if >0 then this is the delay between one callback ending and the next
starting; if <0 then this is the negative of the time between the starts of the callbacks. The value of 0 is treated as 1
• callback the repeating timer callback function
• user_data user data to pass to store in the repeating_timer structure for use by the callback.
• out the pointer to the user owned structure to store the repeating timer info in. BEWARE this storage location must
outlive the repeating timer, so be careful of using stack space

from mbed_rpi_pico_timerinterrupt.

Can you try to modify MBED_RPi_Pico_TimerInterrupt.hpp#L134 from

to

_timerCount[_timerNo] = (uint64_t) ( ( float) TIM_CLOCK_FREQ / frequency ) - 1;

and see if better

from mbed_rpi_pico_timerinterrupt.

The real code of mbed_rp2040 core, relied by this library, is hidden in the variants/RASPBERRY_PI_PICO/libs/libmbed.a precompiled library file, and we have no way to check if it's doing correctly or not.

from mbed_rpi_pico_timerinterrupt.

Re: line 134. Should it be -1 or -2 ?

from mbed_rpi_pico_timerinterrupt.

After replacing with (-1, not -2)

_timerCount[_timerNo] = (uint64_t) ( ( float) TIM_CLOCK_FREQ / frequency ) - 1;

The result running your first code is better

Starting ITimer OK, millis() = 1729
0
2729
1000
1000
1000
1000
1000
1000
1000

from mbed_rpi_pico_timerinterrupt.

It's good. It's possibly a little off at 50 kHz. Hard to be sure. Scope says it's 39.8 us instead of 40.

from mbed_rpi_pico_timerinterrupt.

It's hard to measure it accurately enough on my scope at 50 kHz. It might be okay.

from mbed_rpi_pico_timerinterrupt.

Try using the RPI_PICO_TimerInterrupt library to see your scope is OK. The timing was checked and OK.

I'll investigate this issue later. If we can't fix it, I have to rewrite the library using SDK directly, not relying on the hidden mbed_rp2040 core functions.

from mbed_rpi_pico_timerinterrupt.

I have a frequency counter that's very accurate. Let me check with that. Of course, I don't know how accurate the Arduino clock is to start with ;-(

from mbed_rpi_pico_timerinterrupt.

Hi @pixpop

The new MBED_RPI_PICO_TimerInterrupt v1.2.0 has just been published. Your contribution is noted in Contributions and Thanks

Releases v1.2.0

1. Fix poor-timer-accuracy bug. Check Poor accuracy on timer interrupt frequency or interval. #4

from mbed_rpi_pico_timerinterrupt.

Hi @pixpop

Your contribution has been spread to the newly published MBED_RP2040_Slow_PWM v1.3.0. Your contribution is also noted in Contributions and Thanks

Releases v1.3.0

1. Fix poor-timer-accuracy bug. Check Poor accuracy on timer interrupt frequency or interval. #4

from mbed_rpi_pico_timerinterrupt.