Does not run with Angular 5 about ng-trim-value-accessor HOT 8 CLOSED

Ok seems not to hard. I can try making a PR.
Infos from:
http://ljn.io/posts/publishing-typescript-projects-with-npm/
https://www.twilio.com/blog/2017/06/writing-a-node-module-in-typescript.html
https://stackoverflow.com/questions/30928253/writing-npm-modules-in-typescript

from ng-trim-value-accessor.

Found some more infos:
The problem could be that you are providing .ts files in the npm package.
See the second half of this comment:

So we don't really support using incorrectly packaged libraries with TS sources. It's something you do at your risk.
angular/angular-cli#8284 (comment)

from ng-trim-value-accessor.

I can now confirm the *.ts files in the library as error source.
As quick check I tried the following:

clone your repo
npm install
npm install --save-dev @types/es6-shim (needed for build)
npm run build
copy the dist/ folder to my-app/node_modules/ng-trim-value-accessor/

My app then builds without problems.

from ng-trim-value-accessor.

Thanks for the report and rundown. Do you mind submitting a PR for that?

from ng-trim-value-accessor.

I don't know if I can help with this. I have no experience in creating modules or in publishing anything on npm yet. I only know, that providing .ts files in a module is wrong from the above linked comment.
So it must be something like "compile before uploading it to npm", but how exactly to do this is the question :-)

from ng-trim-value-accessor.

@moritz-h Can you please verify whether the latest version works for you?

from ng-trim-value-accessor.

@khashayar Looks good. ng serve runs now also without --aot. In node_module/ng-trim-value-accessor/ are now only the .js and .d.ts files. No other .ts sources. 👍

from ng-trim-value-accessor.

Great! Thanks for the PR!

from ng-trim-value-accessor.