Git Product home page Git Product logo

Comments (8)

kentcdodds avatar kentcdodds commented on May 23, 2024

Oh, and to be clear/complete, I'm using:

  • node - v6
  • npm - v3.8.5
  • aphrodite - v0.3.0

from aphrodite.

kentcdodds avatar kentcdodds commented on May 23, 2024

If someone gives me direction on this, I'd happily submit a pull request 👍

from aphrodite.

xymostech avatar xymostech commented on May 23, 2024

Huh! That's very interesting! I'll look into it. I wish we had a "sandbox" where we could play around with this stuff, it's hard to test out the generated CSS right now :P

from aphrodite.

xymostech avatar xymostech commented on May 23, 2024

It looks the new version of inline-style-prefix-all is giving different results than an older version did. Using version 1.0.5 (which we have in our package.json) is working fine for me, but updating to version 1.1.0 is breaking things. :(

robinweser/inline-style-prefix-all@545af4f seems to be the offending commit. This probably should have been a major version bump for them, instead of a minor version. I guess we should pin to version 1.0.5?

from aphrodite.

kentcdodds avatar kentcdodds commented on May 23, 2024

I wish we had a "sandbox" where we could play around with this stuff

Maybe this is helpful? http://www.webpackbin.com/4Ja0Rc2l-?

Or this: http://esnextb.in/?gist=918dda026d65d313adfa0498aca5de6a

from aphrodite.

kentcdodds avatar kentcdodds commented on May 23, 2024

Anyway, yes, that should have been a version bump. Here's what I recommend:

  1. Pin the dependency in aphrodite.
  2. Release a patch release of aphrodite
  3. File an issue on inline-style-prefix-all and let them decide how they want to deal with it
  4. Update inline-style-prefix-all when they've dealt with it
  5. (optionally) Release another patch release of aphrodite with that update

from aphrodite.

xymostech avatar xymostech commented on May 23, 2024

Well since aphrodite generates CSS, I'd like to have a sandbox that shows you the generated css!

Okay, I'm making a new release now.

from aphrodite.

kentcdodds avatar kentcdodds commented on May 23, 2024

I'd like to have a sandbox that shows you the generated css!

Would definitely be cool to have an app that does this. We could probably do this in jsbin... :-)

from aphrodite.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.