Git Product home page Git Product logo

Comments (5)

xymostech avatar xymostech commented on May 25, 2024

Woah. Didn't know that 31 tag limit was a thing! We could probably make an option to append to an existing <style> tag instead of making a new one each time.

from aphrodite.

zgotsch avatar zgotsch commented on May 25, 2024

Yeah, you can probably just create one with an id the first time and then getElementById subsequent injections.

from aphrodite.

jlfwong avatar jlfwong commented on May 25, 2024

Thanks for the bug report! Glad we got this now and not in production :)

It sounds like webpack does many style tag insertions by default, but detects when its in <= IE9, and then switches automatically to appending to a single style tag. Shouldn't be too hard to implement.

It would probably be good to land #1 too to help with this problem too.

from aphrodite.

xymostech avatar xymostech commented on May 25, 2024

I looked into the perf implications of this, it looks like using more style tags is faster than appending to a style tag each time, but not appending to a style tag all the time is way better. I'm gonna look into this now.

from aphrodite.

xymostech avatar xymostech commented on May 25, 2024

Oops, forgot to link to the jsperf: http://jsperf.com/append-to-style-vs-create-new-style

from aphrodite.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.