Git Product home page Git Product logo

Comments (5)

kevinbarabash avatar kevinbarabash commented on May 24, 2024 4

paddingVertical and paddingHorizontal sound nice... I always have trouble remember the order of the numbers. I was try to avoid having to do string manipulation... in particular having to append the px makes me sad when everything else is so nice.

from aphrodite.

xymostech avatar xymostech commented on May 24, 2024 1

I don't, I think it's in webapp somewhere. I think it's better to return all 4 of them so that aphrodite can do the unit affixing instead of the mixin (the mixin was made outside of aphrodite): https://github.com/Khan/webapp/blob/master/javascript/content-library-package/styles/shared.js#L54

from aphrodite.

jaredly avatar jaredly commented on May 24, 2024

ReactNative has paddingVertical and paddingHorizontal to replace the shortcut padding: 5px 10px.
For the border example, I've seen stuff like

border: `2px solid ${color}`

from aphrodite.

xymostech avatar xymostech commented on May 24, 2024

I think that if we allow arrays, it's going to be to do something like

display: flex;
display: -ms-flex;

as display: ["flex", "-ms-flex"] because there's currently no way to do that? Not sure.

I think someone has a mixin that lets you do something like

{
    ...padding(5, 10, 15, 20),
}

which would expand to

{
    paddingTop: 5,
    paddingRight: 10,
    paddingBottom: 15,
    paddingLeft: 20,
}

Would that sorta solve your problem @kevinbarabash?

from aphrodite.

kevinbarabash avatar kevinbarabash commented on May 24, 2024

having some simple helper functions sounds good. padding could return either:

{
    paddingTop: 5,
    paddingRight: 10,
    paddingBottom: 15,
    paddingLeft: 20,
}

or

{
    padding: `5px 10px 15px 20px`
}

@xymostech is it "better" to use shorthand forms? Also, do you remember the name of the mixin?

from aphrodite.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.