Comments (6)
Glad I read this issue before adding this to my project.
Personally I would prefer just to remove the "self." and do a direct assignment because all of these seem to be in the init functions anyway (pointers should be nil at this point). When using "self." the setter is used, which retains the object, and you're passing an autoreleased object. If you assign it directly you avoid using an autorelease and the retainCount is balanced in the dealloc regardless of whether the property is "retain" or "assign". If for some reason later the property was changed to "assign" you won't loose the object by doing a direct assignment (because object ins alloc'ed in init, and released in dealloc).
from inappsettings.
I found some leaks and fixed them. I attached the patch.
from inappsettings.
From and email:
I’ve found that Instruments/leak detection is finding a number of leaks, even when using sample app. I’m hoping it is something I am doing incorrectly here.
For example, when I init default values from my app delegate, leaks are reported in the in the InAppSetttingsRegisterDefaults loadFile function. There are 12 leaks reported. It appears that the retain count of ‘setting’ is 2 immediately before its release.
I’d appreciate any suggestions you may have.
from inappsettings.
I had posted this original message back on June 2 and was wondering if you would have an updated version of the code soon with the memory leaks fixed?
Thanks
from inappsettings.
I haven't been writing iOS apps recently so I haven't looked into this issue.
from inappsettings.
I'll need to look into this, hopefully it's fixed with ARC
from inappsettings.
Related Issues (20)
- Changes don't save and table doesn't scroll HOT 2
- Hide some settings unless a toggle value is enabled HOT 1
- Make keyboard dismissable HOT 1
- Dynamically add specifiers HOT 1
- Control length and content of TextField HOT 1
- Add help field HOT 1
- Add delegate methods for when settings change HOT 6
- navigationController nil when pushing multi-value VC HOT 1
- cell highlighting in 2.0
- scroll to text cell in 2.0
- Color of header title HOT 1
- Add support for OnlyDisplayOnInterfaceIdiom HOT 1
- Update readme HOT 1
- Revamp pushing the content out of the way of the keyboard
- Update the sample app
- Add support for PSRadioGroupSpecifier HOT 1
- iOS7 Issue with the Slider setting HOT 2
- Reload if a setting is changed in the settings app while in background
- Allow customization of fonts, text size, etc
- ViewForHeaderInSection.. How to change colors - reopening prior issue HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from inappsettings.