iLBC Codec about csipsimple HOT 10 CLOSED

For iLBC it was integrated in the first versions of CSipSimple (I use pjsip :
http://www.pjsip.org/ as native sip stack which i ported to android).

But after a lot of searches, I conclude that ilbc is not well designed for 
mobile
phone, so I removed it from my builds to make the lib size less important.

What i planned for this point is to provide multiple sources for the native 
library
that will enable me (or other providers) to distribute differents versions of 
the
native library (with or without codecs).

So for now, iLBC is postponed, but when this mechanism will be implemented i'll
provide libs with more codecs implemented.
If you want a build with ilbc activated, I can provide it to you (I've just one 
line
to uncomment in the toolchain and click on build ;) ).

For the issue with G729 that is absolutely not clear for me. 
I know that there is licensed implementation (the one already included in pjsip 
-the
IPP intel one- is under license i think), but there is also opensource
implementations (one has been done by the developer of Siphon - pjsip ported on
iphone). I'll ask him how he solve this codec license issue for siphon and g729.

If necessary for G729 i'll provide an different update source with the lib 
compiled
with g729 and users will have to pay the license fee (either by their own means 
or
-in the worst case- i can imagine to retail license if it's more practical for 
users)

Either ilbc or g729 would provide a serious point of difference over other 
solutions. 

Since this has been added to the latest release.  Should this be marked as 
solved?

Yes now, it's pushed on the android market.

I mark issues as fixed only when on the market in order to avoid duplicates.

I can't get ilbc to work.  Phone keeps choosing GSM even though ilbc is at top 
of codec list.  (Presuming the info saying GSM is correct.)  Provider (2talk) 
lists iLBC as "MUST be 30ms/13.33kbps variant".  Is that what csip uses?

Thanks.

According to the pjsip documentation, 30ms variant is supported.
Are you sure your remote contact support and has ilbc set as the preferred 
codec?
Even if both endpoint support ilbc, sdp negociation can lead to the choose of 
GSM codec if it is prefered by your remote contact.

What I should implement to allow you to really force the use of ilbc is the 
option to disable a codec.

Hi, using the latest csip release, I disabled all codecs but iLBC, but still in 
the stats it says I'm connecting using GSM.  Not sure if that's possible...?

Disabled all other codecs at provider end.  iLBC then worked, so thats a win.  
But it means that the codec preferred order/disable doesn't work?

Cheers.

Ok, there is probably a mistake on my side. 
I didn't really tested the feature yet. So I'll do it and find where is the 
problem.

About ilbc, is the sound quality / latency good?

Whenever, using iLBC, the sound coming through is all garblely.  r618.  Other 
end hears me fine.  It's not a recent regression, I've been using GSM and then 
729 instead.  But I thought I would follow this up.